Changeset 17809 for main/waeup.kofa

Timestamp:

4 Jun 2024, 07:54:30 (4 months ago)

Author:

Henrik Bettermann

Message:

Limit the file name length to 65 characters.

Location:

main/waeup.kofa/trunk

Files:

• CHANGES.txt (modified) (1 diff)
• src/waeup/kofa/browser/pages.py (modified) (10 diffs)
• src/waeup/kofa/browser/templates/datacenteruploadpage.pt (modified) (1 diff)
• src/waeup/kofa/browser/tests/test_browser.py (modified) (1 diff)

main/waeup.kofa/trunk/CHANGES.txt

@@ -4 +4 @@
 1.8.2.dev0 (unreleased)
 =======================
+
+* Limit the file name length to 65 characters.
 
 * Make the certificate's longtitle customizable.

main/waeup.kofa/trunk/src/waeup/kofa/browser/pages.py

@@ -338 +338 @@
 
 #
-# Login/logout and language switch pages...
+# Login/logout and language switch pages
 #
 
@@ -532 +532 @@
 
 #
-# Contact form...
+# Contact form
 #
 
@@ -624 +624 @@
 
 #
-# University related pages...
+# University related pages
 #
 
@@ -840 +840 @@
 
 #
-# User container pages...
+# User container pages
 #
 
@@ -1186 +1186 @@
 
 #
-# Search pages...
+# Search pages
 #
 
@@ -1214 +1214 @@
 
 #
-# Configuration pages...
+# Configuration pages
 #
 
@@ -1344 +1344 @@
 
 #
-# Datacenter pages...
+# Datacenter pages
 #
 
@@ -1498 +1498 @@
                 return
             normalized_filename = self.getNormalizedFileName(filename)
+            if len(normalized_filename.split('.')[0]) > 65:
+                self.flash(_("Maximum file name length is 65 characters! "
+                             "Please choose a shorter file name."),
+                           type='danger')
+                return
             finished_file = os.path.join(
                 self.context.storage, 'finished', normalized_filename)
@@ -2558 +2563 @@
 
 #
-# Courses pages
 #
 class CoursePage(KofaDisplayFormPage, LocalRoleAssignmentUtilityView):
@@ -2747 +2751 @@
 
 #
-# Certificate course pages...
+# CertificateCourse pages...
 #
 class CertificateCoursePage(KofaPage):

main/waeup.kofa/trunk/src/waeup/kofa/browser/templates/datacenteruploadpage.pt

@@ -34 +34 @@
   </div>
 </div>
-<br />
+<br /><br />
+<span i18n:translate="">
+  Please note that the file name must not exceed 65 characters
+  (including the officer's user name, which will become part of the file name).
+</span>
 <form method="post" enctype="multipart/form-data">
 <br />

main/waeup.kofa/trunk/src/waeup/kofa/browser/tests/test_browser.py

@@ -225 +225 @@
         return
 
+    def test_forbidden_filename(self):
+        self.browser.addHeader('Authorization', 'Basic mgr:mgrpw')
+        self.browser.open(self.datacenter_path)
+        self.assertEqual(self.browser.headers['Status'], '200 Ok')
+        self.assertEqual(self.browser.url, self.datacenter_path)
+        self.browser.getLink("Upload data").click()
+        file = open(FORBIDDEN_FILE)
+        ctrl = self.browser.getControl(name='uploadfile:file')
+        file_ctrl = ctrl.mech_control
+        file_ctrl.add_file(file, filename='123456789012345678901234567890123456789012345678901234567890123456.csv')
+        self.browser.getControl('Upload').click()
+        self.assertTrue(
+            'Maximum file name length is 65 characters!'
+            in self.browser.contents)
+
 class DataCenterUIExportTests(UniversitySetup, FunctionalAsyncTestCase):
     # Tests for DataCenter class views and pages.