Changeset 17280

Timestamp:

14 Jan 2023, 04:57:11 (2 years ago)

Author:

uli

Message:

Upgrade dolmen.beaker dependency. Requires new buildout run.

Location:

main/waeup.kofa/trunk

Files:

• CHANGES.txt (modified) (1 diff)
• etc/site.zcml.in (modified) (2 diffs)
• src/waeup/kofa/beaker.py (deleted)
• src/waeup/kofa/ftesting.zcml (modified) (3 diffs)
• src/waeup/kofa/tests/test_beaker.py (modified) (2 diffs)
• versions.cfg (modified) (3 diffs)

main/waeup.kofa/trunk/CHANGES.txt

@@ -4 +4 @@
 1.8.1.dev0 (unreleased)
 =======================
+
+* Upgrade `dolmen.beaker` dependency. Removes other outdated crypto
+  dependencies. Requires new buildout run. Moves cookie configuration from code
+  to site.zcml session config.
 
 * Beautify INSTALL.txt.

main/waeup.kofa/trunk/etc/site.zcml.in

@@ -1 +1 @@
 <configure xmlns="http://namespaces.zope.org/zope"
+           xmlns:browser="http://namespaces.zope.org/browser"
            xmlns:kofa="http://namespaces.waeup.org/kofa"
            i18n_domain="${kofa_params:devel_pkg}">
@@ -80 +81 @@
              principal="zope.manager" />
    </configure>
+
+   <!-- session -->
+   <browser:beakerSession
+        key="waeup.kofa.session.id"
+        secret="KofaRocks"
+        timeout="3600"
+        type="cookie"
+        validate_key="thisMightBeChanged"
+        />
+
 </configure>

main/waeup.kofa/trunk/src/waeup/kofa/ftesting.zcml

@@ -1 +1 @@
 <configure
    xmlns="http://namespaces.zope.org/zope"
+   xmlns:browser="http://namespaces.zope.org/browser"
    xmlns:kofa="http://namespaces.waeup.org/kofa"
    i18n_domain="waeup.kofa"
@@ -50 +51 @@
       principal="zope.Everybody"
       />
-  <grant 
+  <grant
       permission="waeup.Anonymous"
       principal="zope.Anybody"
@@ -70 +71 @@
   <grant role="zope.Manager" principal="zope.mgr" />
 
+   <!-- session -->
+   <browser:beakerSession
+        key="waeup.kofa.session.id"
+        secret="KofaRocks"
+        timeout="3600"
+        type="cookie"
+        validate_key="thisMightBeChanged"
+        />
+
 </configure>

main/waeup.kofa/trunk/src/waeup/kofa/tests/test_beaker.py

@@ +1 @@
+# We test beaker functionality, although we have no beaker-related code
+# anymore. All configuration is done in ZCML snippets in
+# site.zcml/ftesting.zcml now.
+# The dolmen.beaker package is developed on: https://github.com/trollfot/dolmen.beaker
+from dolmen.beaker.interfaces import ISessionConfig
+from zope.component import queryUtility
 from zope.component.hooks import setSite
 from zope.publisher.browser import TestRequest
 from zope.session.interfaces import ISession
 from waeup.kofa.testing import FunctionalLayer, FunctionalTestCase
+
 
 class BeakerTests(FunctionalTestCase):
@@ -18 +25 @@
         setSite(self.getRootFolder()) # needed to start transaction
         request = TestRequest()
-        session = ISession(request)
+        session = ISession(request)  # this is a Zope session
         self.assertTrue(session.__module__.startswith('dolmen.beaker'))
+        self.assertTrue(session.get("_path", None) is not None)
         return
+
+    def test_beaker_session_values(self):
+        # Ensure we get also a beaker session
+        # (which is part of a Zope session)
+        try:
+            import dolmen.beaker
+        except ImportError:
+            # no beaker installed, no test
+            return
+        setSite(self.getRootFolder()) # needed to start transaction
+        config = ISessionConfig
+        request = TestRequest()
+        session = ISession(request).session
+        self.assertEqual(session.__module__, "beaker.session")
+        self.assertTrue(session.get("_path", None) is not None)
+        return
+
+    def test_beaker_config_accessible(self):
+        # The session config is set in site.zcml / ftesting.zcml
+        # See beakerSession directive
+        # See https://github.com/trollfot/dolmen.beaker/blob/master/src/dolmen/beaker/zcml.py
+        # for options
+        config = queryUtility(ISessionConfig)
+        self.assertEqual(config.get("key"), "waeup.kofa.session.id")
+        self.assertEqual(config.get("timeout"), 3600)

main/waeup.kofa/trunk/versions.cfg

@@ -10 +10 @@
 alabaster = 0.7.7
 Babel = 1.3
-Beaker = 1.6.4
+Beaker = 1.11.0
 collective.recipe.sphinxbuilder = 0.8.2
 collective.recipe.template = 2.1
@@ -17 +17 @@
 distribute = 0.6.49
 docutils = 0.11
-dolmen.beaker = 0.1
+dolmen.beaker = 0.4
 experimental.cssselect = 0.3
+funcsigs = 1.0.2
 grok = 1.1.1
 grokcore.view = 1.13.5
@@ -47 +48 @@
 psutil = 2.1.3
 py = 1.0.2
-pycryptopp = 0.6.0.1206569328141510525648634803928199668821045408958
 Pygments = 2.0.2
 pyprof2calltree = 1.1.1