Changeset 17111 for main/waeup.uniben/trunk

Timestamp:

29 Sep 2022, 06:18:06 (2 years ago)

Author:

Henrik Bettermann

Message:

Change discounts for old students.

Location:

main/waeup.uniben/trunk/src/waeup/uniben

Files:

• browser/pages.py (modified) (2 diffs)
• locales/en/LC_MESSAGES/waeup.kofa.mo (modified) (previous)
• locales/en/LC_MESSAGES/waeup.kofa.po (modified) (1 diff)
• students/tests/test_browser.py (modified) (2 diffs)
• students/utils.py (modified) (4 diffs)

main/waeup.uniben/trunk/src/waeup/uniben/browser/pages.py

@@ -84 +84 @@
         'ratio',
         'custom_textline_1', 'custom_textline_2',
-        'custom_float_2')
+        )
 
 class CustomCertificateManageFormPage(CertificateManageFormPage):
@@ -92 +92 @@
         'ratio',
         'custom_textline_1', 'custom_textline_2',
-        'custom_float_2', 'code')
+        'code')

main/waeup.uniben/trunk/src/waeup/uniben/locales/en/LC_MESSAGES/waeup.kofa.po

@@ -46 +46 @@
 
 msgid "Custom Float 1 (not used)"
-msgstr "Old Returning Discount"
+msgstr "New Students Discount (entry session < 2020)"
+
+msgid "Custom Float 2 (not used)"
+msgstr "Returning Students Discount (entry session < 2020)"
 
 msgid ""

main/waeup.uniben/trunk/src/waeup/uniben/students/tests/test_browser.py

@@ -608 +608 @@
         # Old returning students may pay less.
         self.certificate.school_fee_2 = 50000.0
-        self.certificate.custom_float_1 = 30000.0
+        self.certificate.custom_float_2 = 30000.0
         error, payment = utils.setPaymentDetails(
             'schoolfee', self.student, None, None, None)
@@ -614 +614 @@
 
         # Staff members pay less.
-        self.certificate.custom_float_1 = None
+        self.certificate.custom_float_2 = None
         self.student.is_staff = True
         error, payment = utils.setPaymentDetails('schoolfee',

main/waeup.uniben/trunk/src/waeup/uniben/students/utils.py

@@ -345 +345 @@
                     else:
                         amount = getattr(certificate, 'school_fee_1', 0.0)
+                        # Old new students get a discount.
+                        if student.entry_session < 2020 \
+                            and certificate.custom_float_1:
+                            amount -= certificate.custom_float_1                        
                 else:
                     if student.is_foreigner:
@@ -350 +354 @@
                     else:
                         amount = getattr(certificate, 'school_fee_2', 0.0)
-                        # Old returning students might get a discount.
-                        if student.entry_session < 2017 \
-                            and certificate.custom_float_1:
-                            amount -= certificate.custom_float_1
+                        # Old returning students get a discount.
+                        if student.entry_session < 2020 \
+                            and certificate.custom_float_2:
+                            amount -= certificate.custom_float_2
             else:
                 if student.state == CLEARED:
@@ -360 +364 @@
                     else:
                         amount = getattr(certificate, 'school_fee_1', 0.0)
+                        # Old new students get a discount.
+                        if student.entry_session < 2020 \
+                            and certificate.custom_float_1:
+                            amount -= certificate.custom_float_1                             
                 elif student.state == PAID and student.is_postgrad:
                     p_session += 1
@@ -402 +410 @@
                         amount = getattr(certificate, 'school_fee_2', 0.0)
                         # Old returning students might get a discount.
-                        if student.entry_session < 2017 \
-                            and certificate.custom_float_1:
-                            amount -= certificate.custom_float_1
+                        if student.entry_session < 2020 \
+                            and certificate.custom_float_2:
+                            amount -= certificate.custom_float_2
                 # PHARMD school fee amount is fixed and previously paid
                 # installments in current session are deducted.