Changeset 17018 for main/waeup.kofa/trunk

Timestamp:

10 Jul 2022, 11:47:16 (2 years ago)

Author:

Henrik Bettermann

Message:

Disable applicant balance payments in base package completely.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/applicants

Files:

• browser.py (modified) (3 diffs)
• tests/test_browser.py (modified) (1 diff)
• utils.py (modified) (2 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/applicants/browser.py

@@ -1067 +1067 @@
     manage_applications = True
     pnav = 3
-    display_actions = [[_('Save'), _('Finally Submit')],
-        [_('Add online payment ticket'),
-         _('Add balance payment ticket'),
-         _('Remove selected tickets')]]
+    
+    @property
+    def display_actions(self):
+        actions = [[_('Save'), _('Finally Submit')],
+                   [_('Add online payment ticket'),
+                    _('Add balance payment ticket'),
+                    _('Remove selected tickets')]]
+        applicants_utils = getUtility(IApplicantsUtils)
+        if self.context.state not in applicants_utils.BALANCE_PAYMENT_STATES:
+            actions[1].pop(1)
+        return actions
 
     @property
@@ -1288 +1295 @@
     submit_state = PAID
     mandate_days = 31
-    balance_payments_states = ()  # not used in base packe
 
     @property
@@ -1327 +1333 @@
             actions = [[_('Save'), _('Finally Submit')],
                 [_('Remove selected tickets')]]
-        if self.context.state in self.balance_payments_states:
+        applicants_utils = getUtility(IApplicantsUtils)
+        if self.context.state in applicants_utils.BALANCE_PAYMENT_STATES:
             actions[1].append(_('Add balance payment ticket'))
         return actions

main/waeup.kofa/trunk/src/waeup/kofa/applicants/tests/test_browser.py

@@ -1086 +1086 @@
         return
 
-    def test_pay_balance(self):
+    # It was only enabled during implementation of balance payments
+    def disabled_test_pay_balance(self):
         # Managers can make balance payment
         self.browser.addHeader('Authorization', 'Basic mgr:mgrpw')

main/waeup.kofa/trunk/src/waeup/kofa/applicants/utils.py

@@ -55 +55 @@
     #: over to the students section.
     ADDITIONAL_FILES = (('Test File','testfile'),)
+    
+    # A list of states which enable balance payments (not used in base package)
+    BALANCE_PAYMENT_STATES = ()
 
     def setPaymentDetails(self, container, payment, applicant):
@@ -93 +96 @@
         as selected by the applicant.
         """
-        if applicant.state not in (PAID, ADMITTED, SUBMITTED, PROCESSED):
+        if applicant.state not in self.BALANCE_PAYMENT_STATES:
             return _('Wrong state.'), None
         p_item = u'Balance'