Changeset 16819 for main/waeup.kofa/trunk/src/waeup/kofa/students/tests

Timestamp:

21 Feb 2022, 09:39:05 (3 years ago)

Author:

Henrik Bettermann

Message:

Enable import of student history.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/students/tests

Files:

• sample_student_data.csv (modified) (1 diff)
• sample_student_data_migration.csv (modified) (1 diff)
• test_batching.py (modified) (4 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/sample_student_data.csv

@@ -1 @@
-student_id,firstname,lastname,reg_number,date_of_birth,matric_number,email,phone,sex,state,password
-X666666,Aaren,Pieri,1,1990-01-02,100000,,1234,M,courses validated,test1234
-Y777777,Claus,Finau,2,1990-01-03,100001,aa@aa.ng,1234,m,courses validated,
-,Susann,Berson,3,1990-01-04,100002,aa@aa.ng,1234,F,courses validated,
-,Else,Mueller,4,1990-01-05,100003,aa@aa.ng,1234,f,school fee paid,
-,,,,,,,,,,
-,,,,  ,,, ,,,
-,,,,<IGNORE>,,,<IGNORE>,,,
-X888888,Alfons,Meier,5,1990-01-02,100004,aa@aa.ng,1234,m,courses validated,
-X999999,Herbert,Mueller,6,1990-01-02,100005,aa@aa.ng,1234,m,courses registered,
-X111111,Fabian,Riester,7,1990-01-02,100006,aa@aa.ng,1234,m,courses validated,
-X222222,Thomas,Kinderman,8,1990-01-02,100007,aa@aa.ng,1234,m,courses validated,
-X333333,Paula,Schall,9,1990-01-02,100008,aa@aa.ng,1234,m,courses registered,
+student_id,firstname,lastname,reg_number,date_of_birth,matric_number,email,phone,sex,state,password,history
+X666666,Aaren,Pieri,1,1990-01-02,100000,,1234,M,courses validated,test1234,"[u'2012-10-23 00:05:39 WAT - Record created by System Admin', u'2012-10-23 00:05:39 WAT - Admitted by System Admin',u""2021-02-21 12:49:12 WAT - State 'graduated' set by System Admin""]"
+Y777777,Claus,Finau,2,1990-01-03,100001,aa@aa.ng,1234,m,courses validated,,
+,Susann,Berson,3,1990-01-04,100002,aa@aa.ng,1234,F,courses validated,,
+,Else,Mueller,4,1990-01-05,100003,aa@aa.ng,1234,f,school fee paid,,
+,,,,,,,,,,,
+,,,,  ,,, ,,,,
+,,,,<IGNORE>,,,<IGNORE>,,,,
+X888888,Alfons,Meier,5,1990-01-02,100004,aa@aa.ng,1234,m,courses validated,,
+X999999,Herbert,Mueller,6,1990-01-02,100005,aa@aa.ng,1234,m,courses registered,,
+X111111,Fabian,Riester,7,1990-01-02,100006,aa@aa.ng,1234,m,courses validated,,
+X222222,Thomas,Kinderman,8,1990-01-02,100007,aa@aa.ng,1234,m,courses validated,,
+X333333,Paula,Schall,9,1990-01-02,100008,aa@aa.ng,1234,m,courses registered,,

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/sample_student_data_migration.csv

@@ -1 @@
-student_id,firstname,lastname,reg_number,date_of_birth,matric_number,email,phone,password,sex,state
-A123456,Aaren,Pieri,1,1990-01-02#,100000,aa@aa.ng,1234,mypw1,m,clearance started
-B123456,Aaren,Finau,2,1990-01-03,100001,aa@aa.ng,1234,mypw1,m,cleared
-C123456,Aaren,Berson,3,1990-01-04,100002,aa@aa.ng,1234,{SSHA}JJBeA47pgGah500NFpuM2tVeLAbM8dxj,m,admitted
-D123456,John,Wolter,4,1990-01-05,100003,aa@aa.ng,1234,mypw1,m,nonsense
-E123456,John,Kennedy,5,1990-01-06,100004,aa@aa.ng,1234,,x,
-F123456,Frank,Meyer,6,1990-01-06,100005,aa@aa.ng,1234,,m,
+student_id,firstname,lastname,reg_number,date_of_birth,matric_number,email,phone,password,sex,state,history
+A123456,Aaren,Pieri,1,1990-01-02#,100000,aa@aa.ng,1234,mypw1,m,clearance started,"[u'2012-10-23 00:05:39 WAT - Record created by System Admin', u'2012-10-23 00:05:39 WAT - Admitted by System Admin',u""2021-02-21 12:49:12 WAT - State 'graduated' set by System Admin""]"
+B123456,Aaren,Finau,2,1990-01-03,100001,aa@aa.ng,1234,mypw1,m,cleared,
+C123456,Aaren,Berson,3,1990-01-04,100002,aa@aa.ng,1234,{SSHA}JJBeA47pgGah500NFpuM2tVeLAbM8dxj,m,admitted,
+D123456,John,Wolter,4,1990-01-05,100003,aa@aa.ng,1234,mypw1,m,nonsense,
+E123456,John,Kennedy,5,1990-01-06,100004,aa@aa.ng,1234,,x,,
+F123456,Frank,Meyer,6,1990-01-06,100005,aa@aa.ng,1234,,m,,
+G123456,Ulli,Meyer,7,1990-01-06,100007,aa@aa.ng,1234,,m,,nonsense

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_batching.py

@@ -420 +420 @@
         self.assertEqual(
             self.app['students']['X666666'].state, 'courses validated')
+        # history was successfully impotrted
+        history = self.app['students']['X666666'].history.messages
+        self.assertEqual(history[0],
+            '2012-10-23 00:05:39 WAT - Record created by System Admin')
+        self.assertTrue(
+            "State 'courses validated' imported by system" in history[3])
+        # history import has been logged
+        logcontent = open(self.logfile).read()
+        self.assertTrue(
+            "history=[u'2012-10-23 00:05:39 WAT - Record created by System Admin'"
+            in logcontent)
         # Two new student_ids have been created.
         self.assertEqual(self.app['students']._curr_stud_id, 1000003)
@@ -514 +525 @@
             self.csv_file_migration, STUDENT_HEADER_FIELDS_MIGRATION)
         content = open(fail_file).read()
-        self.assertEqual(num_warns,2)
+        self.assertEqual(num_warns,3)
         assert len(self.app['students'].keys()) == 5
         self.assertEqual(
             content,
-            'reg_number,firstname,student_id,sex,email,phone,state,date_of_birth,lastname,password,matric_number,--ERRORS--\r\n'
-            '4,John,D123456,m,aa@aa.ng,1234,nonsense,1990-01-05,Wolter,mypw1,100003,state: not allowed\r\n'
-            '5,John,E123456,x,aa@aa.ng,1234,<IGNORE>,1990-01-06,Kennedy,<IGNORE>,100004,sex: Invalid value\r\n'
+            'reg_number,firstname,student_id,sex,email,phone,state,date_of_birth,lastname,password,matric_number,history,--ERRORS--\r\n'
+            '4,John,D123456,m,aa@aa.ng,1234,nonsense,1990-01-05,Wolter,mypw1,100003,<IGNORE>,state: not allowed\r\n'
+            '5,John,E123456,x,aa@aa.ng,1234,<IGNORE>,1990-01-06,Kennedy,<IGNORE>,100004,<IGNORE>,sex: Invalid value\r\n'
+            '7,Ulli,G123456,m,aa@aa.ng,1234,<IGNORE>,1990-01-06,Meyer,<IGNORE>,100007,nonsense,history: malformed string\r\n'
             )
         students = self.app['students']
@@ -532 +544 @@
                          datetime.date(1990, 1, 3))
         self.assertTrue(students['B123456'].clearance_locked)
-        history = ' '.join(students['A123456'].history.messages)
+        history = students['A123456'].history.messages
+        self.assertEqual(history[0],
+            '2012-10-23 00:05:39 WAT - Record created by System Admin')
         self.assertTrue(
-            "State 'clearance started' set by system" in history)
+            "State 'clearance started' imported by system" in history[3])
         # state was empty and student is thus in state created
         self.assertEqual(students['F123456'].state,'created')
@@ -723 +737 @@
         self.assertEqual(self.student.current_mode, 'ug_pt')
         shutil.rmtree(os.path.dirname(fin_file))
-        # Transer has bee logged.
+        # Transfer has bee logged.
         logcontent = open(self.logfile).read()
         self.assertTrue(