Changeset 16679

Timestamp:

13 Oct 2021, 07:10:12 (3 years ago)

Author:

Henrik Bettermann

Message:

Make deepcopy first before removing items from the list. Otherwise items will be skipped in the for loop.

File:

• main/waeup.kofa/trunk/src/waeup/kofa/students/export.py (modified) (2 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/students/export.py

@@ -20 +20 @@
 import os
 import grok
+from copy import deepcopy
 from datetime import datetime, timedelta
 from zope.component import getUtility
@@ -155 +156 @@
             for level in student['studycourse'].values():
                 # check if already failed or not taken courses have been passed later
-                for code in failedticketcodes:
-                    if code in level.passed_params[6]:
+                failedticketcodes_copy = deepcopy(failedticketcodes)
+                nottakenticketcodes_copy = deepcopy(nottakenticketcodes)
+                for code in failedticketcodes_copy:
+                    if code.strip('m_').strip('_m') in level.passed_params[6]:
                         failedticketcodes.remove(code)
-                for code in nottakenticketcodes:
+                for code in nottakenticketcodes_copy:
                     if code in level.passed_params[6]:
                         nottakenticketcodes.remove(code)