Changeset 16231 for main

Timestamp:

10 Sep 2020, 07:22:19 (4 years ago)

Author:

Henrik Bettermann

Message:

Implement ContactApplicantFormPage.

Location:

main/waeup.kofa/trunk

Files:

• CHANGES.txt (modified) (1 diff)
• src/waeup/kofa/applicants/browser.py (modified) (2 diffs)
• src/waeup/kofa/applicants/tests/test_browser.py (modified) (7 diffs)
• src/waeup/kofa/applicants/viewlets.py (modified) (3 diffs)

main/waeup.kofa/trunk/CHANGES.txt

@@ -4 +4 @@
 1.6.1.dev0 (unreleased)
 =======================
+
+* Implement `ContactApplicantFormPage`.
 
 * Use `Applicant.createStudent` method also to create graduated

main/waeup.kofa/trunk/src/waeup/kofa/applicants/browser.py

@@ -66 +66 @@
 from waeup.kofa.permissions import get_users_with_local_roles
 from waeup.kofa.students.interfaces import IStudentsUtils
+from waeup.kofa.students.browser import ContactStudentFormPage
 from waeup.kofa.utils.helpers import string_from_bytes, file_size, now
 from waeup.kofa.widgets.datewidget import (
@@ -712 +713 @@
             return form_fields
         return form_fields
+
+class ContactApplicantFormPage(ContactStudentFormPage):
+    grok.context(IApplicant)
+    grok.name('contactapplicant')
+    grok.require('waeup.viewApplication')
+    pnav = 3
 
 class CreateStudentPage(UtilityView, grok.View):

main/waeup.kofa/trunk/src/waeup/kofa/applicants/tests/test_browser.py

@@ -37 +37 @@
 from zope.security.interfaces import Unauthorized
 from zope.testbrowser.testing import Browser
+from zope.interface import implementedBy
+from zope.schema.fieldproperty import FieldProperty
 from hurry.workflow.interfaces import IWorkflowInfo, IWorkflowState
 from waeup.kofa.browser.tests.test_pdf import samples_dir
@@ -583 +585 @@
     layer = FunctionalLayer
 
+    def setUp(self):
+        super(ApplicantUITests, self).setUp()
+        self.setup_logging()
+        return
+
+    def tearDown(self):
+        super(ApplicantUITests, self).tearDown()
+        self.teardown_logging()
+        return
+
+    def setup_logging(self):
+        # setup a log-handler that catches all fake mailer output
+        self.stream = StringIO()
+        handler = logging.StreamHandler(self.stream)
+        logger = logging.getLogger('test.smtp')
+        logger.addHandler(handler)
+        logger.setLevel(logging.INFO)
+        return
+
+    def get_fake_smtp_output(self):
+        # get output generated by fake mailer
+        self.stream.flush()
+        self.stream.seek(0)
+        return self.stream.read()
+
+    def teardown_logging(self):
+        # remove the log handler for fake mailer output
+        logger = logging.getLogger('test.smtp')
+        handlers = [x for x in logger.handlers]
+        for handler in handlers:
+            logger.removeHandler(handler)
+        return
+
     def test_manage_and_view_applicant(self):
         # Managers can manage applicants
@@ -623 +658 @@
         # If applicant is in correct state the pdf slip can be opened.
         IWorkflowState(self.applicant).setState('submitted')
-        self.browser.open(self.manage_path)
+        self.browser.open(self.view_path)
         self.browser.getLink("Download application slip").click()
         self.assertEqual(self.browser.headers['Status'], '200 Ok')
@@ -924 +959 @@
         file_ctrl.add_file(pseudo_image, filename='myphoto.jpg')
         self.browser.getControl("Save").click() # submit form
-        self.browser.open(self.manage_path)
+        self.browser.open(self.view_path)
         self.browser.getLink("Download application slip").click()
         self.assertEqual(self.browser.headers['Status'], '200 Ok')
@@ -1331 +1366 @@
         return
 
+    def test_manage_contact_applicant(self):
+        # Managers can contact student
+        self.browser.addHeader('Authorization', 'Basic mgr:mgrpw')
+        # Remove required FieldProperty attribute first ...
+        delattr(Applicant, 'email')
+        # ... and replace by None
+        self.applicant.email = None
+        # Now we have to add  the FieldProperty attribute again. Otherwise
+        # many other tests below will fail.
+        iface = list(implementedBy(Applicant))[0]
+        field_property = FieldProperty(iface['email'])
+        setattr(Applicant, 'email', field_property)
+        self.browser.open(self.view_path)
+        self.browser.getLink("Send email").click()
+        self.browser.getControl(
+            name="form.subject").value = 'Important subject'
+        self.browser.getControl(name="form.body").value = 'Hello!'
+        self.browser.getControl("Send message now").click()
+        self.assertTrue(
+            'An smtp server error occurred' in self.browser.contents)
+        self.applicant.email = 'xx@yy.zz'
+        self.browser.getControl("Send message now").click()
+        self.assertTrue('Your message has been sent' in self.browser.contents)
+        self.assertMatches(
+            'Sending email from no-reply@waeup.org to xx@yy.zz:'
+            '\nMessage:'
+            '\nmsg: MIME-Version: 1.0'
+            '\nmsg: Content-Type: text/plain; charset="us-ascii"'
+            '\nmsg: Content-Transfer-Encoding: 7bit'
+            '\nmsg: From: Manager <no-reply@waeup.org>'
+            '\nmsg: To: Joan None <xx@yy.zz>'
+            '\nmsg: Reply-To: Manager <contact@waeup.org>'
+            '\nmsg: Subject: Important subject'
+            '\nmsg:'
+            '\nmsg: Hello!'
+            '\nmsg:'
+            '\nmsg: ---'
+            '\nmsg: Manager (id: zope.mgr)'
+            '\nmsg: Sample University'
+            '\nmsg:',
+            self.get_fake_smtp_output()
+            )
+        return
+
 
 class ApplicantRegisterTests(ApplicantsFullSetup):
@@ -1956 +2035 @@
         # Managers can remind referees
         self.browser.addHeader('Authorization', 'Basic mgr:mgrpw')
-        self.browser.open(self.manage_path)
+        self.browser.open(self.view_path)
         self.browser.getLink("Remind referees").click()
         self.assertTrue('2 referee(s) have been reminded by email.'
@@ -2035 +2114 @@
         report.email = 'linda@forest.de'
         self.applicant[report.r_id] = report
-        self.browser.open(self.manage_path)
+        self.browser.open(self.view_path)
         self.browser.getLink("Remind referees").click()
         self.assertTrue('1 referee(s) have been reminded by email.'

main/waeup.kofa/trunk/src/waeup/kofa/applicants/viewlets.py

@@ -242 +242 @@
     grok.require('waeup.viewApplication')
     grok.name('pdfactionbutton')
+    grok.view(ApplicantDisplayFormPage)
     icon = 'actionicon_pdf.png'
     text = _('Download application slip')
@@ -275 +276 @@
     grok.context(IApplicant)
     grok.require('waeup.manageApplication')
+    grok.view(ApplicantDisplayFormPage)
     icon = 'actionicon_alarm.png'
     text = _('Remind referees')
@@ -293 +295 @@
             return
         return self.view.url(self.view.context, self.target)
+
+class ContactActionButton(ManageActionButton):
+    grok.order(6)
+    grok.context(IApplicant)
+    grok.view(ApplicantDisplayFormPage)
+    grok.require('waeup.viewApplication')
+    icon = 'actionicon_mail.png'
+    text = _('Send email')
+    target = 'contactapplicant'
 
 class PaymentReceiptActionButton(ManageActionButton):