Changeset 16186

Timestamp:

4 Aug 2020, 07:49:51 (4 years ago)

Author:

Henrik Bettermann

Message:

reg_number is no longer a required field in IApplicantBaseData.

Add entry_session to student data exporters.

Location:

main/waeup.kofa/trunk

Files:

• CHANGES.txt (modified) (1 diff)
• src/waeup/kofa/applicants/interfaces.py (modified) (1 diff)
• src/waeup/kofa/students/export.py (modified) (2 diffs)
• src/waeup/kofa/students/tests/test_browser.py (modified) (2 diffs)
• src/waeup/kofa/students/tests/test_export.py (modified) (4 diffs)

main/waeup.kofa/trunk/CHANGES.txt

@@ -4 +4 @@
 1.6.1.dev0 (unreleased)
 =======================
+
+* `reg_number` is no longer a required field in `IApplicantBaseData`.
+
+* Add `entry_session` to student data exporters.
 
 * Add `DownloadTranscript` permission.

main/waeup.kofa/trunk/src/waeup/kofa/applicants/interfaces.py

@@ -379 +379 @@
         title = _(u'Registration Number'),
         readonly = False,
-        required = True,
+        required = False,
         source = contextual_reg_num_source,
         )

main/waeup.kofa/trunk/src/waeup/kofa/students/export.py

@@ -328 +328 @@
     fields = tuple(sorted(iface_names(IStudent))) + (
         'password', 'state', 'history', 'certcode', 'is_postgrad',
-        'current_level', 'current_session')
+        'current_level', 'current_session', 'entry_session')
     title = _(u'Students (Data Backup)')
 
@@ -371 +371 @@
         'current_level',
         'current_session',
-        'current_verdict')
+        'current_verdict',
+        'entry_session')
     title = _(u'Students (Trimmed Data)')
 

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_browser.py

@@ -3953 +3953 @@
             'sex,student_id,suspended,suspended_comment,'
             'password,state,history,certcode,is_postgrad,'
-            'current_level,current_session\r\n'
+            'current_level,current_session,entry_session\r\n'
             ',,1981-02-04#,aa@aa.ng,,Anna,,Tester,234,,,,,,,'
             '1234#,123,m,K1000000,0,,{SSHA}' in self.browser.contents)
@@ -4084 +4084 @@
             'sex,student_id,suspended,suspended_comment,'
             'password,state,history,certcode,is_postgrad,'
-            'current_level,current_session\r\n'
+            'current_level,current_session,entry_session\r\n'
             ',,1981-02-04#,aa@aa.ng,,Anna,,Tester,234,,,,,,,'
             '1234#,123,m,K1000000,0,,{SSHA}' in self.browser.contents)

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_export.py

@@ -168 +168 @@
             'perm_address,personal_updated,'
             'phone,reg_number,sex,student_id,suspended,suspended_comment,'
-            'password,state,history,'
-            'certcode,is_postgrad,current_level,current_session\r\n'
+            'password,state,history,certcode,is_postgrad,'
+            'current_level,current_session,entry_session\r\n'
             'my adm code,my clr code,'
             '1981-02-04#,anna@sample.com,,Anna,,Tester,234,M.,NG,,,'
             '"Studentroad 21\nLagos 123456\n",,+234-123-12345#,123,f,'
             'A111111,0,,,created'
-            in result
-            )
-        return
-
-
-class StudentTrimmedDataExporterTest(StudentImportExportSetup):
-
-    layer = FunctionalLayer
-
-    std_csv_entry = (
-        'my adm code,my clr code,1981-02-04#,anna@sample.com,,'
-        'Anna,,Tester,234,M.,NG,,,"Studentroad 21\nLagos 123456\n",,'
-        '+234-123-12345#,123,f,A111111,0,,,created'
-        )
-
-    def setUp(self):
-        super(StudentTrimmedDataExporterTest, self).setUp()
-        self.setup_for_export()
-        return
-
-    def test_ifaces(self):
-        # make sure we fullfill interface contracts
-        obj = TrimmedDataExporter()
-        verifyObject(ICSVStudentExporter, obj)
-        verifyClass(ICSVStudentExporter, TrimmedDataExporter)
-        return
-
-    def test_get_as_utility(self):
-        # we can get an student exporter as utility
-        result = queryUtility(ICSVExporter, name="trimmed")
-        self.assertTrue(result is not None)
-        return
-
-    def test_export(self):
-        # we can really export students
-        # set values we can expect in export file
-        self.setup_student(self.student)
-        exporter = TrimmedDataExporter()
-        exporter.export([self.student], self.outfile)
-        result = open(self.outfile, 'rb').read()
-        self.assertTrue(
-            'student_id,matric_number,reg_number,firstname,middlename,'
-            'lastname,sex,email,phone,nationality,date_of_birth,state,'
-            'current_mode,certcode,faccode,depcode,current_level,'
-            'current_session,current_verdict\r\n'
-            'A111111,234,123,Anna,M.,Tester,f,anna@sample.com,+234-123-12345#,'
-            'NG,1981-02-04#,created,ug_ft,CERT1,NA,NA,200,2012,0'
             in result
             )
@@ -238 +191 @@
             'perm_address,personal_updated,'
             'phone,reg_number,sex,student_id,suspended,suspended_comment,'
-            'password,state,history,certcode,'
-            'is_postgrad,current_level,current_session\r\n'
+            'password,state,history,certcode,is_postgrad,'
+            'current_level,current_session,entry_session\r\n'
             'my adm code,my clr code,1981-02-04#,anna@sample.com,,'
             'Anna,,Tester,234,M.,NG,,,"Studentroad 21\nLagos 123456\n"'
@@ -259 +212 @@
             'perm_address,personal_updated,'
             'phone,reg_number,sex,student_id,suspended,suspended_comment,'
-            'password,state,history,certcode,'
-            'is_postgrad,current_level,current_session\r\n'
+            'password,state,history,certcode,is_postgrad,'
+            'current_level,current_session,entry_session\r\n'
             'my adm code,my clr code,1981-02-04#,anna@sample.com,,'
             'Anna,,Tester,234,M.,NG,,,"Studentroad 21\nLagos 123456\n"'
@@ -373 +326 @@
         self.assertTrue(self.std_csv_entry in result1)
         self.assertTrue(self.std_csv_entry not in result2)
+        return
+
+
+
+class StudentTrimmedDataExporterTest(StudentImportExportSetup):
+
+    layer = FunctionalLayer
+
+    std_csv_entry = (
+        'my adm code,my clr code,1981-02-04#,anna@sample.com,,'
+        'Anna,,Tester,234,M.,NG,,,"Studentroad 21\nLagos 123456\n",,'
+        '+234-123-12345#,123,f,A111111,0,,,created'
+        )
+
+    def setUp(self):
+        super(StudentTrimmedDataExporterTest, self).setUp()
+        self.setup_for_export()
+        return
+
+    def test_ifaces(self):
+        # make sure we fullfill interface contracts
+        obj = TrimmedDataExporter()
+        verifyObject(ICSVStudentExporter, obj)
+        verifyClass(ICSVStudentExporter, TrimmedDataExporter)
+        return
+
+    def test_get_as_utility(self):
+        # we can get an student exporter as utility
+        result = queryUtility(ICSVExporter, name="trimmed")
+        self.assertTrue(result is not None)
+        return
+
+    def test_export_all(self):
+        # we can really export students
+        # set values we can expect in export file
+        self.setup_student(self.student)
+        exporter = TrimmedDataExporter()
+        exporter.export_all(self.app, self.outfile)
+        result = open(self.outfile, 'rb').read()
+        self.assertTrue(
+            'student_id,matric_number,reg_number,firstname,middlename,'
+            'lastname,sex,email,phone,nationality,date_of_birth,state,'
+            'current_mode,certcode,faccode,depcode,current_level,'
+            'current_session,current_verdict,entry_session\r\n'
+            'A111111,234,123,Anna,M.,Tester,f,anna@sample.com,+234-123-12345#,'
+            'NG,1981-02-04#,created,ug_ft,CERT1,NA,NA,200,2012,0,2010'
+            in result
+            )
         return