Changeset 16027 for main/waeup.kofa/trunk/src/waeup/kofa

Timestamp:

6 Mar 2020, 19:56:56 (5 years ago)

Author:

Henrik Bettermann

Message:

• Bugfix: If level_session of a studylevel object has changed, coursetickets_catalog must be informed. Otherwise lecturers don't see their students.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/students

Files:

• studylevel.py (modified) (2 diffs)
• tests/test_browser.py (modified) (2 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/students/studylevel.py

@@ -27 +27 @@
 from zope.component import createObject, queryUtility, getUtility
 from zope.interface import implementedBy
+from zope.event import notify
 from waeup.kofa.interfaces import academic_sessions_vocab, VALIDATED, IKofaUtils
 from waeup.kofa.students.interfaces import (
@@ -33 +34 @@
 from waeup.kofa.students.vocabularies import StudyLevelSource
 from waeup.kofa.interfaces import MessageFactory as _
+
+@grok.subscribe(IStudentStudyLevel, grok.IObjectModifiedEvent)
+def handle_update_coursetickets(studylevel, event):
+    """If level_session has changed, coursetickets_catalog
+    must be informed.
+    """
+    # Catalog must be informed
+    for ticket in studylevel.values():
+        notify(grok.ObjectModifiedEvent(ticket))
+    return
 
 def find_carry_over(ticket):

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_browser.py

@@ -4474 +4474 @@
         self.app['users']['mrslecturer'].title = u'Mercedes Benz'
         # Add course ticket
-        studylevel = createObject(u'waeup.StudentStudyLevel')
-        studylevel.level = 100
-        studylevel.level_session = 2004
+        self.studylevel = createObject(u'waeup.StudentStudyLevel')
+        self.studylevel.level = 100
+        self.studylevel.level_session = 2004
         self.student['studycourse'].addStudentStudyLevel(
-            self.certificate, studylevel)
+            self.certificate, self.studylevel)
         # Assign local Lecturer role for a course.
         course = self.app['faculties']['fac1']['dep1'].courses['COURSE1']
@@ -4626 +4626 @@
         self.assertTrue(
             self.browser.getControl(name="scores:list") is not None)
+        # if level_session of studycourse changes, catalog has been updated
+        # and student disappears
+        self.studylevel.level_session = 2005
+        self.browser.reload()
+        self.assertRaises(
+            LookupError, self.browser.getControl, name="scores")
 
     def test_score_editing_can_change_scores(self):