Changeset 15916

Timestamp:

10 Jan 2020, 12:14:21 (5 years ago)

Author:

Henrik Bettermann

Message:

Catch socket error.

File:

• main/kofacustom.nigeria/trunk/src/kofacustom/nigeria/remita/helpers.py (modified) (2 diffs)

main/kofacustom.nigeria/trunk/src/kofacustom/nigeria/remita/helpers.py

@@ -78 +78 @@
     try:
         h.request("GET", url, headers=headers)
+        resp = h.getresponse()
     except:
         return {'error': 'Socket Error: Connection to Remita gateway refused.'}
-    resp = h.getresponse()
     if resp.status!=200:
         return {'error': 'Connection error (%s, %s)' % (resp.status, resp.reason)}
@@ -113 +113 @@
     payment.r_desc = jr['message']
     payment.r_amount_approved = jr['amount']
-    payment.r_pay_reference = jr['RRR']
+    try:
+        payment.r_pay_reference = jr['RRR']
+    except KeyError:
+        msg = _('Error: ${a}', mapping = {'a': payment.r_desc})
+        log = 'unsuccessful response for %s payment %s: %s' % (
+            payment.p_category, payment.p_id, payment.r_desc)
+        payment.p_state = 'failed'
+        notify(grok.ObjectModifiedEvent(payment))
+        return False, msg, log
     #payment.r_company = u'remita'
     if payment.r_code not in ('00', '01'):