Changeset 15418

Timestamp:

21 May 2019, 10:08:08 (6 years ago)

Author:

Henrik Bettermann

Message:

Add student history message if a graduated student was created.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/students

Files:

• batching.py (modified) (2 diffs)
• browser.py (modified) (1 diff)
• tests/test_browser.py (modified) (1 diff)

main/waeup.kofa/trunk/src/waeup/kofa/students/batching.py

@@ -234 +234 @@
                 value = row['state']
                 IWorkflowState(obj).setState(value)
-                notify(grok.ObjectModifiedEvent(obj))
                 msg = _("State '${a}' set", mapping = {'a':value})
                 history = IObjectHistory(obj)
@@ -268 +267 @@
                 '%s - %s - %s - imported: %s' 
                 % (self.name, filename, obj.student_id, items_changed))
+        notify(grok.ObjectModifiedEvent(obj))
         return items_changed
 

main/waeup.kofa/trunk/src/waeup/kofa/students/browser.py

@@ -377 +377 @@
         IWorkflowState(student).setState(GRADUATED)
         notify(grok.ObjectModifiedEvent(student))
-        self.flash(_('Student record created.'))
+        history = IObjectHistory(student)
+        history.addMessage("Set to 'graduated'")
+        self.flash(_('Graduated student record created.'))
         self.redirect(self.url(self.context[student.student_id], 'index'))
         return

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_browser.py

@@ -442 +442 @@
         self.browser.getControl(name="form.reg_number").value = '1234'
         self.browser.getControl("Create graduated student").click()
-        self.assertTrue('Student record created' in self.browser.contents)
+        self.assertTrue('Graduated student record created' in self.browser.contents)
         self.assertEqual(self.app['students']['K1000001'].state, 'graduated')
+        self.browser.open("http://localhost/app/students/K1000001/history")
+        self.assertTrue("Set to 'graduated' by Manager" in self.browser.contents)
         return