Changeset 15416 for main/waeup.kofa/trunk/src/waeup/kofa/students

Timestamp:

21 May 2019, 08:02:51 (6 years ago)

Author:

Henrik Bettermann

Message:

Backup deleted graduated student data somewhere else to ease graduated student data migration.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/students

Files:

• batching.py (modified) (1 diff)
• student.py (modified) (1 diff)
• tests/test_student.py (modified) (3 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/students/batching.py

@@ -652 +652 @@
     `ticket_session` is an additional attribute which can be used to store the 
     session of the course when it was taken. Usually this information is 
-    redundantbecause the the parent study level object already contains this 
+    redundant because the the parent study level object already contains this
     information except for the study level zero container which can be used to
     store 'orphaned' course tickets.

main/waeup.kofa/trunk/src/waeup/kofa/students/student.py

@@ -486 +486 @@
     del_dir = site['datacenter'].deleted_path
 
+    if student.state == GRADUATED:
+        del_dir = site['datacenter'].graduated_path
+
     # save files of the student
     move_student_files(student, del_dir)

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_student.py

@@ -30 +30 @@
 from zope.interface import verify
 from zope.schema.interfaces import RequiredMissing
+from hurry.workflow.interfaces import IWorkflowState
 from waeup.kofa.interfaces import IExtFileStore, IFileStoreNameChooser
 from waeup.kofa.students.student import (
@@ -180 +181 @@
             del_dir, 'media', 'students', '00110', 'A111111',
             'passport_A111111.jpg')
-
         # The image was copied over
         self.assertTrue(os.path.isfile(del_img_path))
@@ -186 +186 @@
             open(del_img_path, 'rb').read(),
             self.image_contents)
-
         # The student data were put into CSV files
         STUDENT_BACKUP_EXPORTER_NAMES = getUtility(
             IStudentsUtils).STUDENT_BACKUP_EXPORTER_NAMES
-
+        for name in STUDENT_BACKUP_EXPORTER_NAMES:
+            csv_path = os.path.join(del_dir, '%s.csv' % name)
+            self.assertTrue(os.path.isfile(csv_path))
+            contents = open(csv_path, 'rb').read().split('\r\n')
+            # We expect 3 lines output including a linebreak at end of file.
+            self.assertEqual(len(contents), 3)
+        return
+
+    def test_backup_single_graduated_data(self):
+        # when a single graduated student is removed, the data is backed up
+        # somewhere else
+        self.setup_student(self.student)
+        IWorkflowState(self.student).setState('graduated')
+        # Add a fake image
+        self.create_passport_img(self.student)
+        handle_student_removed(self.student, None)
+        del_dir = self.app['datacenter'].graduated_path
+        del_img_path = os.path.join(
+            del_dir, 'media', 'students', '00110', 'A111111',
+            'passport_A111111.jpg')
+        # The image was copied over
+        self.assertTrue(os.path.isfile(del_img_path))
+        self.assertEqual(
+            open(del_img_path, 'rb').read(),
+            self.image_contents)
+        # The student data were put into CSV files
+        STUDENT_BACKUP_EXPORTER_NAMES = getUtility(
+            IStudentsUtils).STUDENT_BACKUP_EXPORTER_NAMES
         for name in STUDENT_BACKUP_EXPORTER_NAMES:
             csv_path = os.path.join(del_dir, '%s.csv' % name)