Changeset 15334

Timestamp:

17 Feb 2019, 19:43:26 (6 years ago)

Author:

Henrik Bettermann

Message:

Add tests and adjust the documentation.

Location:

main/waeup.kofa/trunk

Files:

• docs/source/userdocs/students/workflow.rst (modified) (1 diff)
• src/waeup/kofa/students/browser.py (modified) (2 diffs)
• src/waeup/kofa/students/tests/test_browser.py (modified) (2 diffs)

main/waeup.kofa/trunk/docs/source/userdocs/students/workflow.rst

@@ -147 +147 @@
 Transcript Officer will see the new request and can either reject
 the request **(-o)** or validate the request **(p)**. Before
-validation course results can be edited or added. After validation
-the entire studycourse including its content is locked. Nobody will
-be able to modify the course lists, neither through the UI nor by
-import. Transcripts can now be electronically signed by Transcript
-Signees. Once all signees have done their job, the Transcript
-Officer can release the transcript **(q)**. A pdf file is created
-and stored in the file system. The transcript pdf slip contains all
-signatures. The dynamic transcript generation is disabled. Nothing
-can be changed now, unless the entire transcript process is reset
-**(-r)** by a Students Manager. Then comments and signatures will be
-removed and the pdf file deleted. The student can start afresh.
-
+validation course results can be edited or added by a Students
+Manager, transcript study level remarks also by Transcript Officers.
+After validation the entire studycourse including its content is
+locked. Nobody will be able to modify the course lists, neither
+through the UI nor by import. Transcripts can now be electronically
+signed by Transcript Signees. Once all signees have done their job,
+the Transcript Officer can release the transcript **(q)**. A pdf
+file is created and stored in the file system. The transcript pdf
+slip contains all signatures. The dynamic transcript generation is
+disabled. Nothing can be changed now, unless the entire transcript
+process is reset **(-r)** by a Students Manager. Then comments and
+signatures will be removed and the pdf file deleted. The student can
+start afresh.
 
 .. _registration_workflow_batch_processing:

main/waeup.kofa/trunk/src/waeup/kofa/students/browser.py

@@ -1709 +1709 @@
         level_title = translate(self.context.level_title, 'waeup.kofa',
             target_language=lang)
-        return _('Edit transcript remark of level ${a}', mapping = {'a':level_title})
+        return _(
+            'Edit transcript remark of level ${a}', mapping = {'a':level_title})
 
     @property
@@ -1719 +1720 @@
     def save(self, **data):
         msave(self, **data)
-        self.redirect(
-            self.url(self.context.student, 'studycourse/validate_transcript')
-            +'#tab4')
+        self.redirect(self.url(self.context.student)
+            + '/studycourse/validate_transcript#tab4')
         return
 

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_browser.py

@@ -2177 +2177 @@
         self.browser.getControl("Save").click()
         self.assertTrue('Form has been saved' in self.browser.contents)
-        # Officer can validate the transcript
+        # Officer can edit transcript remarks and validate the transcript
         self.browser.open(self.studycourse_path + '/transcript')
         self.browser.getLink("Validate transcript").click()
+        self.browser.getLink("Edit").click()
+        self.assertEqual(
+            self.browser.url, self.studycourse_path + '/100/remark')
+        self.browser.getControl(
+            name="form.transcript_remark").value = 'Oh, the student failed'
+        self.browser.getControl(
+            "Save remark and go and back to transcript validation page").click()
+        self.assertEqual(
+            self.browser.url,
+            self.studycourse_path + '/validate_transcript#tab4')
+        self.assertEqual(self.student['studycourse']['100'].transcript_remark,
+            'Oh, the student failed')
         self.browser.getControl("Save comment and validate transcript").click()
         # After validation all manage forms are locked.
@@ -2189 +2201 @@
         self.assertTrue('The requested form is locked' in self.browser.contents)
         self.browser.open(self.studycourse_path + '/100/COURSE1/manage')
+        self.assertTrue('The requested form is locked' in self.browser.contents)
+        self.browser.open(self.studycourse_path + '/100/remark')
         self.assertTrue('The requested form is locked' in self.browser.contents)