Changeset 14951

Timestamp:

9 Feb 2018, 18:49:18 (7 years ago)

Author:

Henrik Bettermann

Message:

Do not display applicant id and error messages in flash message box. This causes an internal server error if list is too long. Show error messages on a 'Student Record Creation Report' page instead.

Location:

main/waeup.kofa/trunk

Files:

• CHANGES.txt (modified) (1 diff)
• src/waeup/kofa/applicants/browser.py (modified) (3 diffs)
• src/waeup/kofa/applicants/browser_templates/createallstudentspage.pt (added)

main/waeup.kofa/trunk/CHANGES.txt

@@ -5 +5 @@
 =======================
 
-* Display applicant id and error messages in flash message box if
-  student creation has failed.
+* Add 'Student Record Creation' Report page.
 
 * Add `CreateStudents` permission and `StudentsCreator` role.

main/waeup.kofa/trunk/src/waeup/kofa/applicants/browser.py

@@ -685 +685 @@
         return
 
-class CreateAllStudentsPage(UtilityView, grok.View):
+class CreateAllStudentsPage(KofaPage):
     """Create all student objects from applicant data
     in the root container or in a specific applicants container only.
@@ -693 +693 @@
     grok.name('createallstudents')
     grok.require('waeup.createStudents')
+    label = _('Student Record Creation Report')
 
     def update(self):
@@ -716 +717 @@
                 created.append(result.applicant_id)
             else:
-                failed.append('%s (%s)' % (result.applicant_id, msg))
+                failed.append(
+                    (result.applicant_id, self.url(result, 'manage'), msg))
                 ob_class = self.__implemented__.__name__.replace(
                     'waeup.kofa.','')
                 applicants_root.logger.info(
                     '%s - %s - %s' % (ob_class, result.applicant_id, msg))
+
         grok.getSite()['configuration'].maintmode_enabled_by = None
-        if len(created):
-            self.flash(_('${a} students successfully created.',
-                mapping = {'a': len(created)}))
-        if len(failed):
-            self.flash(_('Student creation failed: ${a}',
-                mapping = {'a':', '.join(failed)}), type='danger')
-        if not len(created) and not len(failed):
-            self.flash(_('No record found.'), type='warning')
-        self.redirect(self.url(self.context))
-        return
-
-    def render(self):
-        return
+        self.successful = ', '.join(created)
+        self.failed = failed
+        return
+
 
 class ApplicationFeePaymentAddPage(UtilityView, grok.View):