Changeset 1491

Timestamp:

25 Feb 2007, 15:06:54 (18 years ago)

Author:

joachim

Message:

move changes out of loop

File:

• WAeUP_SRP/trunk/skins/waeup_utilities/fixLevelForNewStudents.py (modified) (3 diffs)

WAeUP_SRP/trunk/skins/waeup_utilities/fixLevelForNewStudents.py

@@ -54 +54 @@
 commit_count = 0
 logger.info("started for %s students" % len(res))
+to_change = {}
 for sbrain in res:
     #count_full += 1
     #rwrite("%s: %s %s %s <br />" % (count_full,sbrain.id,sbrain.entry_mode,sbrain.level))
     student_obj = getattr(students,sbrain.id)
+    changed = False
     if sbrain.entry_mode == "":
         if not student_obj.hasObject('application'):
             rwrite("%s %s %s application not found <br />" % (sbrain.id,sbrain.entry_mode,level))
             continue
+        changed = True
         app_doc = student_obj.application.getContent()
         entry_mode = app_doc.entry_mode
@@ -67 +70 @@
         entry_mode = sbrain.entry_mode
     if entry_mode == "DE":
+        changed = True
         level = "200"
     else:
         level = "100"
-    students_cat.modifyRecord(id=sbrain.id,
-                              level=level,
-                              entry_mode=entry_mode)
+    if changed:
+        d = {}
+        d['id'] = sbrain.id
+        d['level'] = level
+        d['entry_mode'] = entry_mode
+        to_change[sbrain.id] = d
+##    students_cat.modifyRecord(id=sbrain.id,
+##                              level=level,
+##                              entry_mode=entry_mode)
     if not student_obj.hasObject('study_course'):
         rwrite("%s %s %s study_course not found <br />" % (sbrain.id,sbrain.entry_mode,level))
@@ -85 +95 @@
         commit_count = 0
     rwrite("%s: %s %s %s <br />" % (count,sbrain.id,entry_mode,level))
+for entry in to_change.keys():
+    students_cat.modifyRecord(**to_change[entry])
 rwrite("finished")
 logger.info("finished  %s students" % count)