Changeset 14453

Timestamp:

24 Jan 2017, 09:32:47 (8 years ago)

Author:

Henrik Bettermann

Message:

Students must not see scores, cas and grades of their registered courses.

Location:

main/waeup.aaue/trunk/src/waeup/aaue/students

Files:

• browser.py (modified) (1 diff)
• browser_templates/courseticketpage.pt (added)
• browser_templates/studylevelpage.pt (modified) (2 diffs)
• tests/test_browser.py (modified) (1 diff)

main/waeup.aaue/trunk/src/waeup/aaue/students/browser.py

@@ -675 +675 @@
     """ Page to display course tickets
     """
-    form_fields = grok.AutoFields(ICustomCourseTicket)
+
+    @property
+    def show_results(self):
+        isStudent = getattr(
+            self.request.principal, 'user_type', None) == 'student'
+        if isStudent:
+            return False
+        return True
+
+    @property
+    def form_fields(self):
+        if self.show_results:
+            return grok.AutoFields(ICustomCourseTicket)
+        else:
+            return grok.AutoFields(ICustomCourseTicket).omit('score').omit('ca')
 
 class CustomCourseTicketManageFormPage(CourseTicketManageFormPage):

main/waeup.aaue/trunk/src/waeup/aaue/students/browser_templates/studylevelpage.pt

@@ -28 +28 @@
       <th i18n:translate="">Cred.</th>
       <th i18n:translate="">Requ.</th>
-      <th i18n:translate="">Score</th>
-      <th i18n:translate="">CA</th>
-      <th i18n:translate="">Grade</th>
+      <th i18n:translate="" tal:condition="view/show_results" >Score</th>
+      <th i18n:translate="" tal:condition="view/show_results" >CA</th>
+      <th i18n:translate="" tal:condition="view/show_results" >Grade</th>
       <th i18n:translate="">CO</th>
       <th i18n:translate="">Auto</th>
@@ -49 +49 @@
       <td tal:condition="view/show_results" tal:content="value/ca|nothing">CA</td>
       <td tal:condition="view/show_results" tal:content="value/grade|nothing">GRADE</td>
-      <td tal:condition="view/show_results" tal:content="value/carry_over">CO</td>
+      <td tal:content="value/carry_over">CO</td>
       <td tal:content="value/automatic">AUTO</td>
     </tr>

main/waeup.aaue/trunk/src/waeup/aaue/students/tests/test_browser.py

@@ -833 +833 @@
         print "Sample PDF pg_course_registration_slip.pdf written to %s" % path
 
+        # Students cant' view scores, cas and grades.
+        self.browser.open(self.student_path + '/studycourse/100')
+        self.assertFalse('Score' in self.browser.contents)
+        self.assertFalse('CA' in self.browser.contents)
+        self.assertFalse('Grade' in self.browser.contents)
+        self.browser.getLink("COURSE1").click()
+        self.browser.open(self.student_path + '/studycourse/100')
+        self.assertFalse('Score' in self.browser.contents)
+        self.assertFalse('CA' in self.browser.contents)
+        self.assertFalse('Grade' in self.browser.contents)
+
     def test_student_2nd_semester_course_registration(self):
         IWorkflowState(self.student).setState('school fee paid')