Changeset 13874

Timestamp:

4 Jun 2016, 08:53:32 (9 years ago)

Author:

Henrik Bettermann

Message:

Bugfix. The order of formscores? depends on Javascript sorting.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/students

Files:

• browser.py (modified) (2 diffs)
• browser_templates/editscorespage.pt (modified) (1 diff)

main/waeup.kofa/trunk/src/waeup/kofa/students/browser.py

@@ -3124 +3124 @@
             return
         if 'UPDATE' in form:
-            tno = 0
             error = ''
             if not editable_tickets:
                 return
             scores = form['scores']
+            sids = form['sids']
             if isinstance(scores, basestring):
                 scores = [scores]
+            if isinstance(sids, basestring):
+                sids = [sids]
+            formvals = dict([(sids[i], scores[i]) for i in range(len(sids))])
             for ticket in editable_tickets:
                 score = ticket.score
-                if scores[tno] == '':
+                sid = ticket.student.student_id
+                if formvals[sid] == '':
                     score = None
                 else:
                     try:
-                        score = int(scores[tno])
+                        score = int(formvals[sid])
                     except ValueError:
                         error += '%s, ' % ticket.student.display_fullname
@@ -3147 +3151 @@
                          ticket.level, ticket.code, score))
                     #notify(grok.ObjectModifiedEvent(ticket))
-                tno += 1
             if error:
                 self.flash(_('Error: Score(s) of %s have not be updated. '

main/waeup.kofa/trunk/src/waeup/kofa/students/browser_templates/editscorespage.pt

@@ -21 +21 @@
           <input type="text" name="scores" class="form-control"
                      tal:attributes="value ticket/score" />
+          <input type="hidden" name="sids"
+                 tal:attributes="value ticket/student/student_id" />
       </td>
       <td tal:condition="not: ticket/editable_by_lecturer"