Changeset 13764

Timestamp:

7 Mar 2016, 08:56:46 (9 years ago)

Author:

Henrik Bettermann

Message:

Require waeup.viewStudent for showing students at course level.

Location:

main/waeup.kofa/trunk/src/waeup/kofa

Files:

• browser/viewlets.py (modified) (1 diff)
• students/browser.py (modified) (1 diff)
• students/tests/test_browser.py (modified) (2 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/browser/viewlets.py

@@ -508 +508 @@
     grok.view(CoursePage)
     grok.name('showcoursestudents')
-    grok.require('waeup.showStudents')
+    grok.require('waeup.viewStudent')
     icon = 'actionicon_student.png'
     text = _('Show students')

main/waeup.kofa/trunk/src/waeup/kofa/students/browser.py

@@ -3023 +3023 @@
     """
     grok.context(ICourse)
+    grok.require('waeup.viewStudent')
 
     session_label = _('Session')

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_browser.py

@@ -1793 +1793 @@
         self.app['users']['mrslecturer'].email = 'mrslecturer@foo.ng'
         self.app['users']['mrslecturer'].title = u'Mercedes Benz'
+        # Add course ticket
+        studylevel = createObject(u'waeup.StudentStudyLevel')
+        studylevel.level = 100
+        studylevel.level_session = 2004
+        self.student['studycourse'].addStudentStudyLevel(
+            self.certificate, studylevel)
         # Assign local Lecturer role for a certificate.
         course = self.app['faculties']['fac1']['dep1'].courses['COURSE1']
@@ -1822 +1828 @@
         self.browser.getLink(
             "http://localhost/app/faculties/fac1/dep1/courses/COURSE1").click()
-        # ... and view the list of students
-        self.browser.getLink("Show students").click()
-        self.browser.getControl(name="session").value = ['2004']
-        self.browser.getControl(name="level").value = ['100']
-        self.browser.getControl("Show").click()
-        self.assertTrue('No student found.' in self.browser.contents)
-        # No student in course so far.
-        self.assertFalse(self.student_id in self.browser.contents)
-        studylevel = createObject(u'waeup.StudentStudyLevel')
-        studylevel.level = 100
-        studylevel.level_session = 2004
-        self.student['studycourse'].addStudentStudyLevel(
-            self.certificate, studylevel)
-        # Now the student has registered the course and can
-        # be seen by the lecturer.
-        self.browser.open("http://localhost/app/faculties/fac1/dep1/courses/COURSE1/students")
-        self.browser.getControl(name="session").value = ['2004']
-        self.browser.getControl(name="level").value = ['100']
-        self.browser.getControl("Show").click()
-        self.assertTrue(self.student_id in self.browser.contents)
-        # Lecturer can neither access the student ...
+        # Lecturers can neither filter students ...
+        self.assertRaises(
+            Unauthorized, self.browser.open,
+            "http://localhost/app/faculties/fac1/dep1/courses/COURSE1/students")
+        # ... nor access the student ...
         self.assertRaises(
             Unauthorized, self.browser.open, self.student_path)