Changeset 13163 for main

Timestamp:

12 Jul 2015, 17:17:48 (9 years ago)

Author:

Henrik Bettermann

Message:

Require exactly 4 jamb subjects when saved with the edit form page.

Testing this is a nightmare because the testbrowser does not support Javascript.

Location:

main/kofacustom.nigeria/trunk/src/kofacustom/nigeria/applicants

Files:

• interfaces.py (modified) (3 diffs)
• tests/test_browser.py (modified) (7 diffs)

main/kofacustom.nigeria/trunk/src/kofacustom/nigeria/applicants/interfaces.py

@@ -68 +68 @@
     )
 
+# Define a validation method for jamb subjects
+class NotExactNumberOfItems(schema.ValidationError):
+    __doc__ = u"Not exactly 4 items selected."
+
+def four_items(value):
+    if len(value) != 4:
+        raise NotExactNumberOfItems(value)
+    return True
+
 class JAMBSubjectSource(SubjectSource):
     """A source for school subjects used in exam documentation.
@@ -233 +242 @@
     jamb_subjects_list = schema.List(
         title = _(u'JAMB Subjects'),
-        default = ['english_language',],
-        required = False,
+        required = False,
+        default = [],
         value_type = schema.Choice(
             vocabulary = jambsubjects
@@ -578 +587 @@
         title = _(u'JAMB Subjects'),
         description = _(u'Select four subjects.'),
-        default = ['english_language',],
-        required = True,
+        required = True,
+        constraint = four_items,
         value_type = schema.Choice(
             vocabulary = jambsubjects

main/kofacustom.nigeria/trunk/src/kofacustom/nigeria/applicants/tests/test_browser.py

@@ -38 +38 @@
 from waeup.kofa.applicants.container import ApplicantsContainer
 from waeup.kofa.applicants.tests.test_batching import ApplicantImportExportSetup
-from waeup.kofa.interfaces import IBatchProcessor
+from waeup.kofa.interfaces import IBatchProcessor, IUserAccount
 from kofacustom.nigeria.testing import FunctionalLayer
 from kofacustom.nigeria.applicants.export import NigeriaApplicantExporter
@@ -46 +46 @@
 app_container_name = u'app%s' % session_1
 pgft_container_name = u'pgft%s' % session_1
+cbt_container_name = u'cbt%s' % session_1
 
 class ApplicantUITest(FunctionalTestCase):
@@ -69 +70 @@
         setSite(app)
 
-        # Add an two different applicants containers
+        # Add three different applicants containers
         self.pgcontainer = ApplicantsContainer()
         self.pgcontainer.code = pgft_container_name
@@ -78 +79 @@
         self.pgcontainer.title = u'This is the %s container' % pgft_container_name
         self.app['applicants'][pgft_container_name] = self.pgcontainer
+
         self.ugcontainer = ApplicantsContainer()
         self.ugcontainer.code = app_container_name
@@ -86 +88 @@
         self.ugcontainer.title = u'This is the %s container' % app_container_name
         self.app['applicants'][app_container_name] = self.ugcontainer
-
         self.ugcontainer.mode = 'update'
         delta = datetime.timedelta(days=10)
         self.ugcontainer.startdate = datetime.datetime.now(pytz.utc) - delta
         self.ugcontainer.enddate = datetime.datetime.now(pytz.utc) + delta
+
+        self.cbtcontainer = ApplicantsContainer()
+        self.cbtcontainer.code = cbt_container_name
+        self.cbtcontainer.prefix = u'cbt'
+        self.cbtcontainer.application_category = u'basic'
+        self.cbtcontainer.year = session_1
+        self.cbtcontainer.application_fee = 300.0
+        self.cbtcontainer.title = u'This is the %s container' % cbt_container_name
+        self.app['applicants'][cbt_container_name] = self.cbtcontainer
+        self.cbtcontainer.mode = 'update'
+        delta = datetime.timedelta(days=10)
+        self.cbtcontainer.startdate = datetime.datetime.now(pytz.utc) - delta
+        self.cbtcontainer.enddate = datetime.datetime.now(pytz.utc) + delta
 
         # Populate university
@@ -128 +142 @@
         self.ugapplicant = self.app['applicants'][app_container_name][
             self.ugapplication_number]
+
+        cbtapplicant = createObject(u'waeup.Applicant')
+        cbtapplicant.firstname = u'Anna'
+        cbtapplicant.lastname = u'Cbt'
+        self.app['applicants'][cbt_container_name].addApplicant(cbtapplicant)
+        self.cbtapplication_number = cbtapplicant.application_number
+        self.cbtapplicant = self.app['applicants'][cbt_container_name][
+            self.cbtapplication_number]
+        IUserAccount(self.cbtapplicant).setPassword('apwd')
+
+        self.login_path = 'http://localhost/app/login'
+        self.logout_path = 'http://localhost/app/logout'
         self.pgapplicant_path = ('http://localhost/app/applicants/%s/%s'
             % (pgft_container_name, self.pgapplication_number))
         self.ugapplicant_path = ('http://localhost/app/applicants/%s/%s'
             % (app_container_name, self.ugapplication_number))
+        self.cbtapplicant_path = ('http://localhost/app/applicants/%s/%s'
+            % (cbt_container_name, self.cbtapplication_number))
 
         self.browser = Browser()
@@ -319 +347 @@
         self.assertEqual(student.nationality, 'NG')
         return
+
+    def test_applicant_access(self):
+        # Applicants can edit their record
+        self.browser.open(self.login_path)
+        self.browser.getControl(
+            name="form.login").value = self.cbtapplicant.applicant_id
+        self.browser.getControl(name="form.password").value = 'apwd'
+        self.browser.getControl("Login").click()
+        self.assertTrue(
+            'You logged in.' in self.browser.contents)
+        self.browser.getLink("Edit application record").click()
+        self.browser.getControl(name="form.date_of_birth").value = '09/09/1988'
+        self.browser.getControl(name="form.lga").value = ['foreigner']
+        self.browser.getControl(name="form.nationality").value = ['NG']
+        self.browser.getControl(name="form.sex").value = ['m']
+        self.browser.getControl(name="form.email").value = 'xx@yy.zz'
+        self.browser.getControl(name="form.course1").value = ['CERT1']
+        self.browser.getControl("Save").click()
+        self.assertMatches('...Not exactly 4 items selected...', self.browser.contents)
+        # Since the testbrowser does not support Javascrip we can't test the
+        # save action which clears jamb_subjects_list on the edit form page
+        # An error would be raised.
+
+        # If we login as manager, we can use the manage form page.
+        self.browser.open(self.logout_path)
+        self.browser.addHeader('Authorization', 'Basic mgr:mgrpw')
+        self.cbtapplicant.jamb_subjects_list = [
+          'english_language', 'fine_art', 'mathematics', 'physics']
+        self.browser.open(self.cbtapplicant_path + '/manage')
+        self.browser.getControl(name="form.date_of_birth").value = '09/09/1988'
+        self.browser.getControl(name="form.lga").value = ['foreigner']
+        self.browser.getControl(name="form.nationality").value = ['NG']
+        self.browser.getControl(name="form.sex").value = ['m']
+        self.browser.getControl(name="form.email").value = 'xx@yy.zz'
+        self.browser.getControl(name="form.course1").value = ['CERT1']
+        self.browser.getControl(name="form.reg_number").value = '1234'
+        self.browser.getControl("Save").click()
+        self.assertMatches('...Form has been saved...', self.browser.contents)
+        # The save action on this form pages, if called with the testbrowser,
+        # replaces jamb_subjects_list by an empty list (and not by None).
+        self.assertEqual(self.cbtapplicant.jamb_subjects_list, [])
 
 class ApplicantExporterTest(ApplicantImportExportSetup):