Changeset 13089

Timestamp:

21 Jun 2015, 15:12:52 (9 years ago)

Author:

Henrik Bettermann

Message:

Clean up code. Remove redundant IApplicantBase interface.

Location:

main/waeup.kofa/trunk/src/waeup/kofa

Files:

• applicants/interfaces.py (modified) (5 diffs)
• browser/interfaces.py (modified) (1 diff)
• browser/layout.py (modified) (1 diff)
• browser/templates/changepw.pt (modified) (1 diff)
• browser/templates/loginpage.pt (modified) (1 diff)
• students/browser.py (modified) (1 diff)

main/waeup.kofa/trunk/src/waeup/kofa/applicants/interfaces.py

@@ -27 +27 @@
 from zope.schema.interfaces import (
     ValidationError, ISource, IContextSourceBinder)
-from waeup.kofa.browser.interfaces import IApplicantBase
 from waeup.kofa.schema import TextLineChoice, FormattedDate
 from waeup.kofa.interfaces import (
@@ -321 +320 @@
     'year'].order =  IApplicantsContainer['year'].order
 
-class IApplicantBaseData(IApplicantBase):
+class IApplicantBaseData(IKofaObject):
     """This is a base interface of an applicant with no field
     required. For use with processors, forms, etc., please use one of
@@ -458 +457 @@
         """
 
-class ISpecialApplicant(IApplicantBase):
+class ISpecialApplicant(IKofaObject):
     """This reduced interface is for former students or students who are not
-    student users of the portal but have to pay supplementary fees.
-
+    users of the portal but have to pay supplementary fees.
     This interface is used in browser components only. Thus we can't add
     fields here to the regular IApplicant interface here. We can
     only 'customize' fields.
     """
-    history = Attribute('Object history, a list of messages')
-    state = Attribute('The application state of an applicant')
-    display_fullname = Attribute('The fullname of an applicant')
-    application_date = Attribute('UTC datetime of submission, used for export only')
-    password = Attribute('Encrypted password of a applicant')
-    application_number = Attribute('The key under which the record is stored')
 
     suspended = schema.Bool(
@@ -582 +574 @@
         )
 
-IApplicantEdit['email'].order = IApplicantEdit[
-    'sex'].order
+IApplicantEdit['email'].order = IApplicantEdit['sex'].order
 
 class IApplicantUpdateByRegNo(IApplicant):
@@ -622 +613 @@
 class IApplicantOnlinePayment(IOnlinePayment):
     """An applicant payment via payment gateways.
-
     """
 

main/waeup.kofa/trunk/src/waeup/kofa/browser/interfaces.py

@@ -190 +190 @@
 
 class IStudentNavigationBase(IKofaObject):
-    """Objects that provide student navigation (whatever it is) should
+    """Objects that provide student navigation should
        implement this interface.
     """
     student = Attribute('''Some student object that has a '''
                         ''' `display_fullname` attribute.''')
-
-class IApplicantBase(IKofaObject):
-    """Some Applicant.
-    """
-    display_fullname = Attribute('''Fullname.''')

main/waeup.kofa/trunk/src/waeup/kofa/browser/layout.py

@@ -35 +35 @@
 from waeup.kofa.interfaces import MessageFactory as _
 from waeup.kofa.utils.helpers import to_timezone
-from waeup.kofa.browser.interfaces import (
-    IStudentNavigationBase, IApplicantBase)
+from waeup.kofa.browser.interfaces import IStudentNavigationBase
 from waeup.kofa.authentication import get_principal_role_manager
 

main/waeup.kofa/trunk/src/waeup/kofa/browser/templates/changepw.pt

@@ -16 +16 @@
     </tbody>
   </table>
-
+  <br />
   <p i18n:translate="email_address_problem">
     Enter the email address stored in Kofa.

main/waeup.kofa/trunk/src/waeup/kofa/browser/templates/loginpage.pt

@@ -30 +30 @@
     Inititialize your student account <strong><a href="requestpw"> here</a></strong>.
   </p>
-  <p i18n:translate="login_trouble3"> Or simply forgot your student id, application id or password? Then request a new password
+  <p i18n:translate="login_trouble3"> Or simply forgot your student id, applicant id or password? Then request a new password
     <strong><a href="changepw"> here</a></strong>.
   </p>

main/waeup.kofa/trunk/src/waeup/kofa/students/browser.py

@@ -1073 +1073 @@
                 return
             # Mark pin as used (this also fires a pin related transition)
-            # and fire transition start_clearance
+            # and fire transition request_transcript
             comment = _(u"invalidated")
             # Here we know that the ac is in state initialized so we do not