Changeset 12775

Timestamp:

16 Mar 2015, 12:53:09 (10 years ago)

Author:

uli

Message:

pep8, pyflakes.

Location:

main/waeup.ikoba/trunk/src/waeup/ikoba/payments

Files:

• browser.py (modified) (2 diffs)
• catalog.py (modified) (1 diff)
• container.py (modified) (1 diff)
• tests/test_browser.py (modified) (5 diffs)
• tests/test_payment.py (modified) (4 diffs)

main/waeup.ikoba/trunk/src/waeup/ikoba/payments/browser.py

@@ -23 +23 @@
 from waeup.ikoba.interfaces import MessageFactory as _
 from waeup.ikoba.browser.viewlets import PrimaryNavTab, ManageActionButton
-from waeup.ikoba.browser.layout import (
-    IkobaPage, IkobaEditFormPage, IkobaDisplayFormPage,
-    NullValidator, jsaction, action, UtilityView)
-from waeup.ikoba.utils.helpers import get_current_principal
-
+from waeup.ikoba.browser.layout import IkobaPage
 from waeup.ikoba.payments.interfaces import (
     IPaymentsContainer, IPayment, payment_states
@@ -192 +188 @@
             self.flash(_('Successfully removed: ${a}',
                 mapping={'a': ','.join(deleted)}))
-            ob_class = self.__implemented__.__name__.replace('waeup.ikoba.','')
+            ob_class = self.__implemented__.__name__.replace(
+                'waeup.ikoba.', '')
             self.context.logger.info(
                 '%s - removed: %s' % (ob_class, ','.join(deleted)))

main/waeup.ikoba/trunk/src/waeup/ikoba/payments/catalog.py

@@ -19 +19 @@
 """
 import grok
-from hurry.query import Eq, Text
+from hurry.query import Eq
 from hurry.query.query import Query
 from zope.catalog.interfaces import ICatalog

main/waeup.ikoba/trunk/src/waeup/ikoba/payments/container.py

@@ -45 +45 @@
         raise NotImplementedError()
 
+
 PaymentsContainer = attrs_to_fields(PaymentsContainer)
+
 
 class PaymentsPlugin(grok.GlobalUtility):

main/waeup.ikoba/trunk/src/waeup/ikoba/payments/tests/test_browser.py

@@ -1 +1 @@
 ## $Id: test_browser.py 12762 2015-03-14 13:49:29Z henrik $
-## 
+##
 ## Copyright (C) 2015 Uli Fouquet & Henrik Bettermann
 ## This program is free software; you can redistribute it and/or modify
@@ -6 +6 @@
 ## the Free Software Foundation; either version 2 of the License, or
 ## (at your option) any later version.
-## 
+##
 ## This program is distributed in the hope that it will be useful,
 ## but WITHOUT ANY WARRANTY; without even the implied warranty of
 ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 ## GNU General Public License for more details.
-## 
+##
 ## You should have received a copy of the GNU General Public License
 ## along with this program; if not, write to the Free Software
@@ -22 +22 @@
 import os
 from decimal import Decimal
-from waeup.ikoba.testing import FunctionalLayer, FunctionalTestCase
+from waeup.ikoba.testing import FunctionalLayer
 from waeup.ikoba.payments.payment import Payment
 from waeup.ikoba.payments.interfaces import IPayer, IPayable
-from waeup.ikoba.browser.tests.test_pdf import samples_dir
 from waeup.ikoba.products.productoptions import ProductOption
 from waeup.ikoba.customers.tests.test_browser import CustomersFullSetup
@@ -67 +66 @@
         self.assertTrue('Empty search string' in self.browser.contents)
         self.browser.getControl(name="searchtype").value = ['payment_id']
-        self.browser.getControl(name="searchterm").value = self.payment.payment_id
+        self.browser.getControl(
+            name="searchterm").value = self.payment.payment_id
         self.browser.getControl("Find payment(s)").click()
         self.assertTrue(
@@ -82 +82 @@
         logcontent = open(logfile).read()
         self.assertTrue(
-            'INFO - zope.mgr - payments.browser.PaymentsContainerManagePage - removed: %s'
+            ('INFO - zope.mgr - payments.browser.'
+             'PaymentsContainerManagePage - removed: %s')
             % self.payment.payment_id in logcontent)

main/waeup.ikoba/trunk/src/waeup/ikoba/payments/tests/test_payment.py

@@ -155 +155 @@
 
     def test_get_payments_from_payer_id(self):
-        # we can lookup payments.
+        # we can lookup payments from payer ids.
         self.getRootFolder()['app'] = Company()
         app = self.getRootFolder()['app']
@@ -161 +161 @@
         p1 = Payment(FakePayer(), FakePayable())
         app['payments']['1'] = p1
-        p_id = p1.payment_id
         result = get_payments_from_payer_id('PAYER_01')
         self.assertTrue(result[0] is p1)
@@ -167 +166 @@
 
     def test_get_payments_from_payable_id(self):
-        # we can lookup payments.
+        # we can lookup payments from payable ids.
         self.getRootFolder()['app'] = Company()
         app = self.getRootFolder()['app']
@@ -173 +172 @@
         p1 = Payment(FakePayer(), FakePayable())
         app['payments']['1'] = p1
-        p_id = p1.payment_id
         result = get_payments_from_payable_id('PAYABLE_01')
         self.assertTrue(result[0] is p1)