Changeset 12647 for main/waeup.ikoba/branches

Timestamp:

2 Mar 2015, 00:46:09 (10 years ago)

Author:

uli

Message:

Consider changed Payment interface.

Location:

main/waeup.ikoba/branches/uli-fake-gw-provider/src/waeup/ikoba/payments

Files:

• demo_provider.py (modified) (1 diff)
• tests/test_demo_provider.py (modified) (3 diffs)

main/waeup.ikoba/branches/uli-fake-gw-provider/src/waeup/ikoba/payments/demo_provider.py

@@ -15 +15 @@
     title = _(u'Demo Creditcard')
 
-    def create_payment(self, payer, payment_item,  payee=None):
+    def create_payment(self, payer, payment_item_list=[],  payee=None):
         """Create a payment.
         """
         payment = Payment()
         payment.gateway_service = 'demo'  # must be grok.name above
-        payment.payed_item_id = payment_item.item_id
-        payment.amount = payment_item.amount
         payment.payer_id = payer.payer_id
+        for item in payment_item_list:
+            payment.add_payment_item(item)
         return payment

main/waeup.ikoba/branches/uli-fake-gw-provider/src/waeup/ikoba/payments/tests/test_demo_provider.py

@@ -27 +27 @@
         service = DemoCreditcardPaymentService()
         payer, payment_item, payee = Payer(), PaymentItem(), Payee()
-        payment_item.item_id = u'SOME_ITEM_ID'
         payer.payer_id = u'SOME_PAYER_ID'
-        result = service.create_payment(payer, payment_item, payee)
+        result = service.create_payment(payer, [], payee)
         assert IPayment.providedBy(result)
         assert result.gateway_service == u'demo'
         assert result.state == STATE_UNPAID
+        assert len(result) == 0  # no items stored
 
     def test_create_payment_honors_payment_item(self):
@@ -41 +41 @@
         payer.payer_id = u'SOME_PAYER_ID'
         payment_item.amount = decimal.Decimal("300.99")
-        result = service.create_payment(payer, payment_item, payee)
-        assert result.payed_item_id == payment_item.item_id
-        assert result.amount == payment_item.amount
+        result = service.create_payment(payer, [payment_item], payee)
+        self.assertEqual(result.amount, payment_item.amount)
+        assert len(result) == 1
 
     def test_create_payment_honors_payer(self):
@@ -51 +51 @@
         payment_item.item_id = u'SOME_ITEM_ID'
         payer.payer_id = u'SOME_PAYER_ID'
-        result = service.create_payment(payer, payment_item, payee)
+        result = service.create_payment(payer, [payment_item], payee)
         assert result.payer_id == payer.payer_id