Changeset 12521 for main/waeup.ikoba/trunk

Timestamp:

30 Jan 2015, 07:48:39 (10 years ago)

Author:

Henrik Bettermann

Message:

Use TextLineChoice? field for cutomer emails and ensure that email addresses are unique.

Location:

main/waeup.ikoba/trunk/src/waeup/ikoba/customers

Files:

• browser_templates/createaccount.pt (modified) (1 diff)
• browser_templates/requestpw.pt (modified) (1 diff)
• interfaces.py (modified) (4 diffs)
• tests/sample_customer_data.csv (modified) (1 diff)
• tests/sample_customer_data_duplicates.csv (modified) (1 diff)
• tests/test_batching.py (modified) (2 diffs)
• tests/test_browser.py (modified) (6 diffs)
• vocabularies.py (modified) (2 diffs)

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/browser_templates/createaccount.pt

@@ -16 +16 @@
     </tbody>
   </table>
+  <br />
   <p i18n:translate="">
     A customer record will be created and

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/browser_templates/requestpw.pt

@@ -16 +16 @@
     </tbody>
   </table>
+  <br />
   <p i18n:translate="">
     Your customer record will be looked up and

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/interfaces.py

@@ -30 +30 @@
 
 from waeup.ikoba.customers.vocabularies import (
-    contextual_reg_num_source, GenderSource, nats_vocab,
+    contextual_reg_num_source, contextual_email_source,
+    GenderSource, nats_vocab,
     ConCatProductSource, CustomerDocumentSource,
     ProductOptionSourceFactory)
@@ -125 +126 @@
         )
 
-    email = schema.ASCIILine(
+    email = TextLineChoice(
         title = _(u'Email'),
         required = False,
         constraint=validate_email,
+        source = contextual_email_source,
         )
 
@@ -195 +197 @@
         )
 
-    email = schema.ASCIILine(
+    email = schema.TextLine(
         title = _(u'Email Address'),
         required = True,
@@ -223 +225 @@
         )
 
-    email = schema.ASCIILine(
-        title = _(u'Email Address'),
-        required = True,
+    email = TextLineChoice(
+        title = _(u'Email'),
+        required = False,
         constraint=validate_email,
+        source = contextual_email_source,
         )
 

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/tests/sample_customer_data.csv

@@ -1 +1 @@
 customer_id,firstname,lastname,reg_number,date_of_birth,,phone,sex,state
 X666666,Aaren,Pieri,1,1990-01-02,aa@aa.ng,1234,M,requested
-Y777777,Claus,Finau,2,1990-01-03,aa@aa.ng,1234,m,requested
-,Susann,Berson,3,1990-01-04,aa@aa.ng,1234,F,requested
-,Else,Mueller,4,1990-01-05,aa@aa.ng,1234,f,approved
-X888888,Alfons,Meier,5,1990-01-02,aa@aa.ng,1234,m,requested
-X999999,Herbert,Mueller,6,1990-01-02,aa@aa.ng,1234,m,approved
-X111111,Fabian,Riester,7,1990-01-02,aa@aa.ng,1234,m,requested
-X222222,Thomas,Kinderman,8,1990-01-02,aa@aa.ng,1234,m,requested
-X333333,Paula,Schall,9,1990-01-02,aa@aa.ng,1234,m,approved
+Y777777,Claus,Finau,2,1990-01-03,bb@aa.ng,1234,m,requested
+,Susann,Berson,3,1990-01-04,cc@aa.ng,1234,F,requested
+,Else,Mueller,4,1990-01-05,dd@aa.ng,1234,f,approved
+X888888,Alfons,Meier,5,1990-01-02,ee@aa.ng,1234,m,requested
+X999999,Herbert,Mueller,6,1990-01-02,ff@aa.ng,1234,m,approved
+X111111,Fabian,Riester,7,1990-01-02,gg@aa.ng,1234,m,requested
+X222222,Thomas,Kinderman,8,1990-01-02,hh@aa.ng,1234,m,requested
+X333333,Paula,Schall,9,1990-01-02,ii@aa.ng,1234,m,approved

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/tests/sample_customer_data_duplicates.csv

@@ -1 +1 @@
 customer_id,firstname,lastname,reg_number,date_of_birth,email,phone,password,sex,state
 A123456,Aaren,Pieri,1,1990-01-02#,aa@aa.ng,1234,mypw1,m,requested
-C123456,Aaren,Berson,2,1990-01-04,aa@aa.ng,1234,mypw1,m,approved
-F123456,Frank,Meyer,1,1990-01-06,aa@aa.ng,1234,,m,
-A123456,Uli,Schulz,3,1990-01-07,aa@aa.ng,1234,,m,
+C123456,Aaren,Berson,2,1990-01-04,bb@aa.ng,1234,mypw1,m,approved
+F123456,Frank,Meyer,1,1990-01-06,cc@aa.ng,1234,,m,
+A123456,Uli,Schulz,3,1990-01-07,dd@aa.ng,1234,,m,
+A234567,Berta,Pieri,4,1991-01-07,aa@aa.ng,1234,,m,

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/tests/test_batching.py

@@ -139 +139 @@
         customer.date_of_birth = datetime.date(1981, 2, 4)
         #customer.sex = 'f'
-        customer.email = 'anna@sample.com'
+        customer.email = u'anna@sample.com'
         customer.phone = u'+234-123-12345'
         customer.notice = u'Some notice\nin lines.'
@@ -279 +279 @@
             self.csv_file_duplicates, CUSTOMER_HEADER_FIELDS_DUPLICATES)
         content = open(fail_file).read()
-        self.assertEqual(num_warns,2)
+        self.assertEqual(num_warns,3)
         self.assertEqual(
             content,
             'reg_number,password,firstname,lastname,sex,phone,state,date_of_birth,customer_id,email,--ERRORS--\r\n'
-            '1,,Frank,Meyer,m,1234,,1990-01-06,F123456,aa@aa.ng,reg_number: Invalid input\r\n'
-            '3,,Uli,Schulz,m,1234,,1990-01-07,A123456,aa@aa.ng,This object already exists. Skipping.\r\n'
-
+            '1,,Frank,Meyer,m,1234,,1990-01-06,F123456,cc@aa.ng,reg_number: Invalid input\r\n'
+            '3,,Uli,Schulz,m,1234,,1990-01-07,A123456,dd@aa.ng,This object already exists. Skipping.\r\n'
+            '4,,Berta,Pieri,m,1234,,1991-01-07,A234567,aa@aa.ng,email: Invalid input\r\n'
             )
         shutil.rmtree(os.path.dirname(fin_file))

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/tests/test_browser.py

@@ -127 +127 @@
         customer.reg_number = u'123'
         customer.sex = u'm'
-        customer.email = 'aa@aa.ng'
+        customer.email = u'aa@aa.ng'
         customer.phone = u'1234'
         customer.date_of_birth = date(1981, 2, 4)
@@ -210 +210 @@
         self.browser.getControl(name="form.reg_number").value = '123'
         self.browser.getControl("Create customer record").click()
-        self.assertTrue('Registration number exists already'
+        self.assertTrue('Registration number does exist.'
             in self.browser.contents)
         self.browser.getControl(name="form.reg_number").value = '1234'
@@ -220 +220 @@
         self.browser.getControl(name="form.reg_number").value = '123'
         self.browser.getControl("Save").click()
-        self.assertMatches('...Registration number exists...',
+        self.assertMatches('...Registration number does exist...',
                            self.browser.contents)
 
@@ -358 +358 @@
         self.browser.getControl("Send message now").click()
         self.assertTrue('An smtp server error occurred' in self.browser.contents)
-        self.customer.email = 'xx@yy.zz'
+        self.customer.email = u'xx@yy.zz'
         self.browser.getControl("Send message now").click()
         self.assertTrue('Your message has been sent' in self.browser.contents)
@@ -420 +420 @@
         open('customers.csv', 'wb').write(
 """firstname,lastname,reg_number,date_of_birth,email,phone,sex,password
-Aaren,Pieri,1,1990-01-02,aa@aa.ng,1234,m,mypwd1
-Claus,Finau,2,1990-01-03,aa@aa.ng,1234,m,mypwd1
-Brit,Berson,2,1990-01-04,aa@aa.ng,1234,m,mypwd1
+Aaren,Pieri,1,1990-01-02,bb@aa.ng,1234,m,mypwd1
+Claus,Finau,2,1990-01-03,cc@aa.ng,1234,m,mypwd1
+Brit,Berson,2,1990-01-04,dd@aa.ng,1234,m,mypwd1
 """)
         self.browser.addHeader('Authorization', 'Basic mgr:mgrpw')
@@ -766 +766 @@
 
     def test_create_account(self):
-        # Customer with wrong number can't be found.
         self.browser.open('http://localhost/app/createaccount')
         self.browser.getControl(name="form.firstname").value = 'Ruben'
         self.browser.getControl(name="form.lastname").value = 'Gonzales'
+        self.browser.getControl(name="form.email").value = 'aa@aa.ng'
+        self.browser.getControl("Send login credentials").click()
+        # Email address exists.
+        self.assertTrue('Email address does exist.' in self.browser.contents)
         self.browser.getControl(name="form.email").value = 'newcustomer@xx.zz'
         self.browser.getControl("Send login credentials").click()
-        self.assertTrue('Your request was successful.'
-            in self.browser.contents)
-        # ... and  customer can be found in the catalog via the email address
+        self.assertTrue('Your request was successful.' in self.browser.contents)
+        # Customer can be found in the catalog via the email address
         cat = queryUtility(ICatalog, name='customers_catalog')
         results = list(

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/vocabularies.py

@@ -62 +62 @@
 
 class RegNumNotInSource(ValidationError):
-    """Registration number exists already
+    """Registration number does exist.
     """
     # The docstring of ValidationErrors is used as error description
     # by zope.formlib.
+    pass
+
+class EmailNotInSource(ValidationError):
+    """Email address does exist.
+    """
     pass
 
@@ -121 +126 @@
 directlyProvides(contextual_reg_num_source, IContextSourceBinder)
 
+class EmailSource(RegNumberSource):
+    field_name = 'email'
+    validation_error = EmailNotInSource
+
+def contextual_email_source(context):
+    source = EmailSource(context)
+    return source
+directlyProvides(contextual_email_source, IContextSourceBinder)
+
 
 class ConCatProductSource(BasicContextualSourceFactory):