Changeset 12447

Timestamp:

12 Jan 2015, 09:24:58 (10 years ago)

Author:

Henrik Bettermann

Message:

Remove redundant code and set download_filename for pdf files.

Location:

main/waeup.kofa/trunk/src/waeup/kofa

Files:

• browser/templates/filedisplay.pt (modified) (1 diff)
• browser/templates/fileupload.pt (modified) (1 diff)
• documents/fileviewlets.py (modified) (3 diffs)
• documents/tests/test_browser.py (modified) (3 diffs)
• students/fileviewlets.py (modified) (3 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/browser/templates/filedisplay.pt

@@ -5 +5 @@
   <td>
     <a tal:attributes="href python: view.url(context, viewlet.download_name)"
-       tal:content="viewlet/download_name"
+       tal:content="viewlet/download_filename"
        target="image">
       LINK

main/waeup.kofa/trunk/src/waeup/kofa/browser/templates/fileupload.pt

@@ -7 +7 @@
     <tal:file tal:condition="viewlet/file_exists">
       <a tal:attributes="href python: view.url(context, viewlet.download_name)"
-         tal:content="viewlet/title"
+         tal:content="viewlet/download_filename"
          target="image">
         LINK

main/waeup.kofa/trunk/src/waeup/kofa/documents/fileviewlets.py

@@ -44 +44 @@
     tab_redirect = '#tab2'
 
+    @property
+    def download_filename(self):
+        return u"%s.pdf" % self.context.document_id
+
 
 class PDFScanDisplay(FileDisplay):
@@ -56 +60 @@
     download_name = u'sample.pdf'
 
+    @property
+    def download_filename(self):
+        return u"%s.pdf" % self.context.document_id
+
 
 class PDFScanImage(UtilityView, Image):
@@ -66 +74 @@
     download_name = u'sample.pdf'
 
+    @property
+    def download_filename(self):
+        return self.context.document_id
+
     def update(self):
         if self.context.state != PUBLISHED:

main/waeup.kofa/trunk/src/waeup/kofa/documents/tests/test_browser.py

@@ -148 +148 @@
             name='upload_pdfscanmanageupload').click()
         self.assertTrue(
-            'href="http://localhost/app/documents/DOC1/sample.pdf">PDF File</a>'
+            'href="http://localhost/app/documents/DOC1/sample.pdf">DOC1.pdf</a>'
             in self.browser.contents)
         # The file can be found in the file system
@@ -159 +159 @@
         # Browsing the link shows a real pdf only if the document
         # has been published
-        self.browser.getLink("PDF File").click()
+        self.browser.getLink("DOC1.pdf").click()
         self.assertTrue(
             'The document requested has not yet been published'
@@ -167 +167 @@
         self.assertEqual(
             self.browser.headers['content-type'], 'application/pdf')
+        # The name of the downloaded file will be different
+        self.assertEqual(
+            self.browser.headers['Content-Disposition'],
+            'attachment; filename="DOC1.pdf')
 
         # Transitions can be performed

main/waeup.kofa/trunk/src/waeup/kofa/students/fileviewlets.py

@@ -120 +120 @@
     label = _(u'File')
     title = _(u'Scan')
-    download_name = u'filename.jpg'
+
+    @property
+    def download_filename(self):
+        return self.download_name
 
     @property
@@ -241 +244 @@
     """
     grok.baseclass()
-    grok.name('none.jpg')
     grok.context(IStudent)
     grok.require('waeup.viewStudent')
-    download_name = u'none.jpg'
+
+    @property
+    def download_filename(self):
+        return self.download_name
 
     def render(self):
@@ -262 +267 @@
         elif ext == '.png':
             self.response.setHeader('Content-Type', 'image/png')
+        elif ext == '.tif':
+            self.response.setHeader('Content-Type', 'image/tiff')
         elif ext == '.pdf':
             self.response.setHeader('Content-Type', 'application/pdf')
-        elif ext == '.tif':
-            self.response.setHeader('Content-Type', 'image/tiff')
+            self.response.setHeader('Content-Disposition',
+                'attachment; filename="%s.pdf' % self.download_filename)
         return image