Changeset 12337 for main

Timestamp:

29 Dec 2014, 23:05:40 (10 years ago)

Author:

Henrik Bettermann

Message:

Improve contract management. Tests will follow which show that customers can only do what they are allowed to do.

Location:

main/waeup.ikoba/trunk/src/waeup/ikoba

Files:

• customers/browser.py (modified) (13 diffs)
• customers/browser_templates/contractaddpage.pt (moved) (moved from main/waeup.ikoba/trunk/src/waeup/ikoba/customers/browser_templates/contractaddform.pt)
• customers/browser_templates/contractsmanagepage.pt (modified) (3 diffs)
• customers/contracts.py (modified) (1 diff)
• customers/export.py (modified) (1 diff)
• customers/interfaces.py (modified) (1 diff)
• customers/viewlets.py (modified) (3 diffs)
• products/interfaces.py (modified) (1 diff)

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/browser.py

@@ -88 +88 @@
     view.redirect(view.url(view.context))
     return
+
+def isCustomer(principal):
+    return getattr(principal, 'user_type', None) == 'customer'
 
 
@@ -1093 +1096 @@
 
 
-class ContractsManageFormPage(IkobaEditFormPage):
-    """ Page to manage the customer contracts
-
-    This manage form page is for both customers and officers.
+class ContractsFormPage(IkobaEditFormPage):
+    """ Page to display, edit or manage customer contracts
+
+    This form page is for both customers and officers.
     """
     grok.context(IContractsContainer)
@@ -1106 +1109 @@
 
     @property
-    def manage_contracts_allowed(self):
+    def edit_contracts_allowed(self):
+        right_customer_state = self.context.customer.state in getUtility(
+            ICustomersUtils).CONMANAGE_CUSTOMER_STATES
+        if isCustomer(self.request.principal) and not right_customer_state:
+            return False
         return checkPermission('waeup.editContracts', self.context)
 
-    def unremovable(self, contract):
-        usertype = getattr(self.request.principal, 'user_type', None)
-        if not usertype:
-            return False
-        if not self.manage_contracts_allowed:
-            return True
-        return (self.request.principal.user_type == 'customer' and \
-            contract.state in (APPROVED, REJECTED, EXPIRED))
+    def remove_contract_allowed(self, contract):
+        if isCustomer(self.request.principal):
+            right_customer_state = self.context.customer.state in getUtility(
+                ICustomersUtils).CONMANAGE_CUSTOMER_STATES
+            if not right_customer_state:
+                return False
+            if contract.state in (APPROVED, REJECTED, EXPIRED):
+                return False
+        return checkPermission('waeup.editContracts', self.context)
 
     @property
@@ -1143 +1151 @@
             # Customers are not allowed to remove used contracts
             contract = self.context.get(id, None)
-            if contract is not None and not self.unremovable(contract):
+            if contract is not None and self.remove_contract_allowed(contract):
                 del self.context[id]
                 deleted.append(id)
@@ -1155 +1163 @@
 
 
-class ContractAddFormPage(IkobaAddFormPage):
+class ContractAddPage(IkobaAddFormPage):
     """ Page to add an contract
+
+    This page is for both customers and officers.
     """
     grok.context(IContractsContainer)
     grok.name('addcontract')
-    grok.template('contractaddform')
+    grok.template('contractaddpage')
     grok.require('waeup.editContracts')
     label = _('Add contract')
@@ -1167 +1177 @@
     form_fields = grok.AutoFields(IContract).omit(
         'product_object', 'contract_id', 'product_options')
+
+    @property
+    def edit_contracts_allowed(self):
+        right_customer_state = self.context.customer.state in getUtility(
+            ICustomersUtils).CONMANAGE_CUSTOMER_STATES
+        if isCustomer(self.request.principal) and not right_customer_state:
+            return False
+        return True
+
+    def update(self):
+        if not self.edit_contracts_allowed:
+            emit_lock_message(self)
+            return
+        return super(ContractAddPage, self).update()
 
     @property
@@ -1187 +1211 @@
         self.context.writeLogMessage(
             self,'added: %s %s' % (contype, contract.contract_id))
-        self.redirect(self.url(self.context))
+        self.redirect(self.url(contract, 'selectproduct'))
         return
 
@@ -1193 +1217 @@
     def cancel(self, **data):
         self.redirect(self.url(self.context))
+
+
+class ContractSelectProductPage(IkobaAddFormPage):
+    """ Page to select a contract product
+
+    This page is for both customers and officers.
+    """
+    grok.context(IContract)
+    grok.name('selectproduct')
+    grok.require('waeup.editContracts')
+    label = _('Select product')
+    pnav = 4
+
+    form_fields = grok.AutoFields(IContract).select('product_object')
+
+    def update(self):
+        if not self.context.is_editable and self.context.product_options == []:
+            emit_lock_message(self)
+            return
+        return super(ContractSelectProductPage, self).update()
+
+    @action(_('Save and proceed'), style='primary')
+    def save(self, **data):
+        msave(self, **data)
+        isCustomer = getattr(
+            self.request.principal, 'user_type', None) == 'customer'
+        if isCustomer:
+            self.redirect(self.url(self.context, 'edit'))
+        else:
+            self.redirect(self.url(self.context, 'manage'))
+        return
 
 
@@ -1227 +1282 @@
     deletion_warning = _('Are you sure?')
 
+    def update(self):
+        if not self.context.is_editable:
+            emit_lock_message(self)
+            return
+        return super(ContractManageFormPage, self).update()
+
     @property
     def form_fields(self):
@@ -1243 +1304 @@
 
 class ContractEditFormPage(ContractManageFormPage):
-    """ Page to edit a contract
+    """ Page to edit a contract by customer only
     """
     grok.name('edit')
@@ -1251 +1312 @@
     def form_fields(self):
         return grok.AutoFields(self.context.edit_form_fields_interface).omit(
-            'contract_id')
-
-    def update(self):
-        if not self.context.is_editable_by_customer:
-            emit_lock_message(self)
-            return
-        return super(ContractEditFormPage, self).update()
+            'contract_id', 'product_object')
 
     @action(_('Save'), style='primary')
@@ -1342 +1397 @@
     def render(self):
         portal_language = getUtility(IIkobaUtils).PORTAL_LANGUAGE
-        Id = translate(_('Id'), 'waeup.ikoba', target_language=portal_language)
+        #Id = translate(_('Id'), 'waeup.ikoba', target_language=portal_language)
         Title = translate(_('Title'), 'waeup.ikoba', target_language=portal_language)
         Type = translate(_('Type'), 'waeup.ikoba', target_language=portal_language)
@@ -1353 +1408 @@
             tabledata.append(sorted(
                 [value for value in self.context.values()]))
-            tableheader.append([(Id, 'contract_id', 2),
+            tableheader.append([
+                             #(Id, 'contract_id', 2),
                              (Title, 'title', 6),
                              (Type, 'translated_class_name', 6),

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/browser_templates/contractsmanagepage.pt

@@ -5 +5 @@
     <thead>
     <tr>
-      <th>&nbsp;</th>
+      <th tal:condition="view/edit_contracts_allowed">&nbsp;</th>
       <th i18n:translate="">Id</th>
       <th i18n:translate="">Title</th>
@@ -14 +14 @@
     </thead>
     <tbody>
-      <tr tal:repeat="cl context/values">
-         <td>
+      <tr tal:repeat="contract context/values">
+         <td tal:condition="view/edit_contracts_allowed">
           <input type="checkbox"
-                 name="val_id"
-                 tal:attributes="value cl/__name__"
-         tal:condition="python: not view.unremovable(cl)" />
+                 name="val_id"
+                 tal:attributes="value contract/__name__"
+           tal:condition="python: view.remove_contract_allowed(contract)" />
         </td>
         <td>
-          <a tal:attributes="href python: view.url(cl)">
-          <span tal:content="cl/contract_id">CONID</span></a>
+          <a tal:attributes="href python: view.url(contract)">
+          <span tal:content="contract/contract_id">CONID</span></a>
         </td>
         <td>
-          <span tal:content="cl/title">TITLE</span>
+          <span tal:content="contract/title">TITLE</span>
         </td>
         <td>
-          <span tal:content="cl/translated_class_name">CLASSNAME</span>
+          <span tal:content="contract/translated_class_name">CLASSNAME</span>
         </td>
         <td>
-          <span tal:content="cl/translated_state">STATE</span>
+          <span tal:content="contract/translated_state">STATE</span>
         </td>
         <td>
-          <span tal:content="cl/formatted_transition_date">
+          <span tal:content="contract/formatted_transition_date">
               LASTTRANSITIONDATE
           </span>
@@ -43 +43 @@
   </table>
 
-  <div tal:condition="python: view.availableActions and view.manage_contracts_allowed">
+  <div tal:condition="python: view.availableActions and view.edit_contracts_allowed">
     <span tal:repeat="action view/actions"
           tal:omit-tag="">

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/contracts.py

@@ -132 +132 @@
 
     @property
-    def is_editable_by_customer(self):
+    def is_editable(self):
         try:
             # Customer must be approved

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/export.py

@@ -214 +214 @@
                       'formatted_transition_date',
                       'translated_class_name',
-                      'is_editable_by_customer',
+                      'is_editable',
                       'is_approvable'])))
 

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/interfaces.py

@@ -290 +290 @@
     last_product_id = Attribute(
         'Id of product recently stored with the contract')
-    is_editable_by_customer = Attribute('Contract editable by customer')
+    is_editable = Attribute('Contract editable by customer and manager')
     is_approvable = Attribute('Contract approvable by officer')
     translated_class_name = Attribute('Translatable class name')

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/viewlets.py

@@ -33 +33 @@
     CustomerBaseDisplayFormPage,
     DocumentsManageFormPage, DocumentDisplayFormPage, DocumentManageFormPage,
-    ContractsManageFormPage, ContractDisplayFormPage,
+    ContractsFormPage, ContractDisplayFormPage,
     ContractManageFormPage)
 
@@ -375 +375 @@
     grok.order(2)
     grok.context(IContractsContainer)
-    grok.view(ContractsManageFormPage)
+    grok.view(ContractsFormPage)
     grok.require('waeup.viewCustomer')
     icon = 'actionicon_pdf.png'
@@ -401 +401 @@
     @property
     def target_url(self):
-        if not self.context.is_editable_by_customer:
+        if not self.context.is_editable:
             return ''
         return self.view.url(self.view.context, self.target)

main/waeup.ikoba/trunk/src/waeup/ikoba/products/interfaces.py

@@ -58 +58 @@
 
     contract_title = schema.TextLine(
-        title = _(u'Product Title'),
-        description = _('Product title if empty'),
+        title = _(u'Contract Title'),
+        description = _('Product title is used if empty.'),
         required = False,
         )