Changeset 12326

Timestamp:

26 Dec 2014, 11:28:59 (10 years ago)

Author:

uli

Message:

We cannot do creditcard payments w/o creditcards.

Location:

main/waeup.ikoba/trunk/src/waeup/ikoba/payments

Files:

• paypal.py (modified) (1 diff)
• tests/test_paypal.py (modified) (2 diffs)

main/waeup.ikoba/trunk/src/waeup/ikoba/payments/paypal.py

@@ -1146 +1146 @@
         if (payee is not None) and (not IPayee.providedBy(payee)):
             payee = IPayee(payee)
+        credit_card = self.get_credit_card(payer.payer_id)
+        if credit_card is None:
+            raise ValueError("Payer %s has no credit card." % payer.payer_id)
         return None
 

main/waeup.ikoba/trunk/src/waeup/ikoba/payments/tests/test_paypal.py

@@ -34 +34 @@
 from waeup.ikoba.interfaces import IPayPalConfig
 from waeup.ikoba.payments.interfaces import (
-    IPaymentGatewayService, IPayer, IPayee, IPaymentItem, IPayment,
+    IPaymentGatewayService, IPayer, IPayee, IPaymentItem,
     )
 from waeup.ikoba.payments.paypal import (
@@ -1142 +1142 @@
         assert service.get_credit_card(u'CARD2') is None
 
-    def DIStest_creditcard_service_can_create_payment(self):
-        # we can create IPayment objects with creditcard service
+    def test_create_payment_no_credictard(self):
+        # trying to create a payment without credit card raises an exception
         service = PayPalCreditCardService()
-        payment = service.create_payment(
-            payer=FakePayer(),
-            payment_item=FakePaymentItem(),
-            payee=FakePayee()
-            )
-        assert IPayment.providedBy(payment)
+        exception = None
+        try:
+            service.create_payment(
+                payer=FakePayer(),
+                payment_item=FakePaymentItem(),
+                payee=FakePayee()
+                )
+        except (ValueError, ) as err:
+            exception = err
+        assert exception.message == 'Payer PAYER-123 has no credit card.'