Changeset 12266

Timestamp:

19 Dec 2014, 16:17:17 (10 years ago)

Author:

Henrik Bettermann

Message:

Add exporter tests and fix exporter.

Location:

main/waeup.ikoba/trunk/src/waeup/ikoba/documents

Files:

• export.py (modified) (3 diffs)
• tests/test_batching.py (modified) (1 diff)
• tests/test_export.py (added)

main/waeup.ikoba/trunk/src/waeup/ikoba/documents/export.py

@@ -27 +27 @@
 
 
-class PDFDocumentExporter(grok.GlobalUtility, ExporterBase):
+class DocumentExporterBase(grok.GlobalUtility, ExporterBase):
     """Exporter for documents.
     """
     grok.implements(ICSVExporter)
-    grok.name('pdfdocuments')
+    grok.baseclass()
+    class_name = None
+    iface = None
+    title = None
 
-    #: Fieldnames considered by this exporter
-    fields = tuple(sorted(iface_names(IPDFDocument))) + (
+    @property
+    def fields(self):
+        return tuple(sorted(iface_names(self.iface))) + (
         'users_with_local_roles',)
-
-    #: The title under which this exporter will be displayed
-    title = _(u'Public PDF Documents')
 
     def mangle_value(self, value, name, context=None):
@@ -48 +49 @@
             for local_role, user_name, setting in role_map.getPrincipalsAndRoles():
                 value.append({'user_name':user_name,'local_role':local_role})
-        return super(PDFDocumentExporter, self).mangle_value(
+        return super(DocumentExporterBase, self).mangle_value(
             value, name, context)
 
@@ -66 +67 @@
         If `filepath` is ``None``, a raw string with CSV data is returned.
         """
-        documents = site.get('documents', {})
-        return self.export(documents.values(), filepath)
+        documents = site.get('documents', {}).values()
+        documents = [doc for doc in documents
+                     if doc.class_name == self.class_name]
+        return self.export(documents, filepath)
 
 
-class HTMLDocumentExporter(PDFDocumentExporter):
+class PDFDocumentExporter(DocumentExporterBase):
+    """Exporter for documents.
+    """
+    grok.name('pdfdocuments')
+    iface = IPDFDocument
+    class_name = 'PDFDocument'
+    title = _(u'Public PDF Documents')
+
+
+class HTMLDocumentExporter(DocumentExporterBase):
     """Exporter for documents.
     """
     grok.name('htmldocuments')
-
-    #: Fieldnames considered by this exporter
-    fields = tuple(sorted(iface_names(IHTMLDocument))) + (
-        'users_with_local_roles',)
-
-    #: The title under which this exporter will be displayed
+    iface = IHTMLDocument
+    class_name = 'HTMLDocument'
     title = _(u'Public HTML Documents')

main/waeup.ikoba/trunk/src/waeup/ikoba/documents/tests/test_batching.py

@@ -79 +79 @@
 
     def setup_for_export(self):
-        document = PDFDocument()
-        self.app['documents'][document.document_id] = self.document = document
+        document1 = PDFDocument()
+        document1.document_id = u'DOC1'
+        self.app['documents'].addDocument(document1)
+        self.pdfdocument = document1
         self.outfile = os.path.join(self.workdir, 'myoutput.csv')
-        role_manager = IPrincipalRoleManager(document)
+        role_manager = IPrincipalRoleManager(document1)
+        role_manager.assignRoleToPrincipal(u'johnsrole', u'john')
+
+        document2 = HTMLDocument()
+        document2.document_id = u'DOC2'
+        self.app['documents'].addDocument(document2)
+        self.htmldocument = document2
+        self.outfile = os.path.join(self.workdir, 'myoutput.csv')
+        role_manager = IPrincipalRoleManager(document2)
         role_manager.assignRoleToPrincipal(u'johnsrole', u'john')
         return