Changeset 12258

Timestamp:

18 Dec 2014, 14:44:30 (10 years ago)

Author:

Henrik Bettermann

Message:

Change contract_id generation algorithm. Use Universally Unique IDentifiers instead of consecutive numbers.

Location:

main/waeup.ikoba/trunk/src/waeup/ikoba

Files:

• app.py (modified) (2 diffs)
• customers/batching.py (modified) (3 diffs)
• customers/browser.py (modified) (4 diffs)
• customers/contracts.py (modified) (2 diffs)
• customers/interfaces.py (modified) (2 diffs)
• utils/batching.py (modified) (1 diff)

main/waeup.ikoba/trunk/src/waeup/ikoba/app.py

@@ -42 +42 @@
     grok.implements(ICompany)
 
-    _curr_con_id = 101
-
     # Setup authentication for this app. Note: this is only
     # initialized, when a new instance of this app is created.
@@ -54 +52 @@
         self.setup()
         return
-
-    @property
-    def unique_contract_id(self):
-        """A unique contract id for all contract objects in customers.
-
-        The contract id returned is guaranteed to be unique.
-
-        Once a contract id was issued, it won't be issued again.
-
-        Obtaining an contract id is currently not thread-safe but can be
-        made easily by enabling commented lines.
-        """
-        # lock.acquire() # lock data
-        new_id = u'c%s' % (self._curr_con_id)
-        self._curr_con_id += 1
-        # self._p_changed = True
-        # commit()
-        # lock.release() # end of lock
-        return new_id
 
     def setup(self):

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/batching.py

@@ -406 +406 @@
         return None
 
-        #documents = self.getParent(row, site)
-        #if documents is None:
-        #    return None
-        #document_id = row.get('document_id', None)
-        #if document_id is None:
-        #    return None
-        #entry = documents.get(document_id)
-        #return entry
-
     def updateEntry(self, obj, row, site, filename):
         """Update obj to the values given in row.
@@ -496 +487 @@
         if contract_id is None:
             return None
-        entry = contracts.get(contract_id)
-        return entry
+        cat = queryUtility(ICatalog, name='contracts_catalog')
+        results = list(cat.searchResults(contract_id=(contract_id, contract_id)))
+        if results:
+            return results[0]
+        return None
 
     def updateEntry(self, obj, row, site, filename):
         """Update obj to the values given in row.
         """
+        # Remove contract_id from row if empty
+        if 'contract_id' in row and row['contract_id'] in (None, IGNORE_MARKER):
+            row.pop('contract_id')
         items_changed = super(ContractProcessor, self).updateEntry(
             obj, row, site, filename)
         customer = self.getParent(row, site).__parent__
         customer.__parent__.logger.info(
-            '%s - %s - %s - updated: %s'
-            % (self.name, filename, customer.customer_id, items_changed))
+            '%s - %s - %s - %s - updated: %s'
+            % (self.name, filename, customer.customer_id, obj.contract_id,
+               items_changed))
         return
 
     def addEntry(self, obj, row, site):
         parent = self.getParent(row, site)
-        contract_id = row['contract_id'].strip('#')
-        parent[contract_id] = obj
-        # Reset _curr_con_id if contract_id has been imported
-        site = grok.getSite()
-        if row.get('contract_id', None) not in (None, IGNORE_MARKER):
-            site._curr_con_id -= 1
+        parent.addContract(obj)
         return
 
@@ -541 +534 @@
             if class_name != self.factory_name.strip('waeup.'):
                 errs.append(('class_name','wrong processor'))
-        try:
-            # Correct con_id counter. As the IConverter for contracts
-            # creates contract objects that are not used afterwards, we
-            # have to fix the site-wide con_id counter.
-            site = grok.getSite()
-            site._curr_con_id -= 1
-        except (KeyError, TypeError, AttributeError):
-                pass
-        # We have to check contract_id.
-        contract_id = row.get('contract_id', None)
-        if mode == 'create':
-            if not contract_id:
-                contract_id = generate_contract_id()
-                conv_dict['contract_id'] = contract_id
-                return errs, inv_errs, conv_dict
-            cat = queryUtility(ICatalog, name='contracts_catalog')
-            results = list(
-                cat.searchResults(contract_id=(contract_id, contract_id)))
-            if results:
-                # contract_id must not exist.
-                errs.append(('contract_id','id exists'))
-        else:
-            if not contract_id.startswith('c'):
-                errs.append(('contract_id','invalid format'))
         return errs, inv_errs, conv_dict

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/browser.py

@@ -1165 +1165 @@
     pnav = 4
 
-    form_fields = grok.AutoFields(IContract).omit('product_object')
+    form_fields = grok.AutoFields(IContract).omit(
+        'product_object', 'contract_id')
 
     @property
@@ -1180 +1181 @@
         # classes depending on the contype parameter given in form.
         contract = createObject('waeup.%s' % contype)
+        self.applyData(contract, **data)
         self.context.addContract(contract)
         contype = getUtility(ICustomersUtils).SELECTABLE_CONTYPES_DICT[contype]
@@ -1227 +1229 @@
     @property
     def form_fields(self):
-        return grok.AutoFields(self.context.form_fields_interface)
+        return grok.AutoFields(self.context.form_fields_interface).omit(
+            'contract_id')
 
     @property
@@ -1247 +1250 @@
     @property
     def form_fields(self):
-        return grok.AutoFields(self.context.edit_form_fields_interface)
+        return grok.AutoFields(self.context.edit_form_fields_interface).omit(
+            'contract_id')
 
     def update(self):

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/contracts.py

@@ -27 +27 @@
 from hurry.workflow.interfaces import IWorkflowInfo, IWorkflowState
 from waeup.ikoba.interfaces import MessageFactory as _
-from waeup.ikoba.interfaces import IIkobaUtils, IObjectHistory, VERIFIED
+from waeup.ikoba.interfaces import (
+    IIkobaUtils, IObjectHistory, VERIFIED, IIDSource)
 from waeup.ikoba.customers.interfaces import (
     IContractsContainer, ICustomerNavigation,
@@ -75 +76 @@
         super(ContractBase, self).__init__()
         # The site doesn't exist in unit tests
-        try:
-            self.contract_id = generate_contract_id()
-        except AttributeError:
-            self.contract_id = u'c999'
+        source = getUtility(IIDSource)
+        self.contract_id = unicode(source.get_hex_uuid())
         self.last_product_id = None
         return

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/interfaces.py

@@ -265 +265 @@
 
     """
-    contract_id = Attribute('Contract Identifier')
     history = Attribute('Object history, a list of messages')
     state = Attribute('Returns the contract state')
@@ -280 +279 @@
     translated_class_name = Attribute('Translatable class name')
 
+    contract_id = schema.TextLine(
+        title = _(u'Contract Id'),
+        required = False,
+        )
+
     title = schema.TextLine(
         title = _(u'Contract Title'),

main/waeup.ikoba/trunk/src/waeup/ikoba/utils/batching.py

@@ -227 +227 @@
                 # Computed attributes can't be set.
                 continue
-            log_value = getattr(value, 'any_id', value)
+            log_value = getattr(value, 'product_id', value)
+            log_value = getattr(value, 'document_id', log_value)
             changed.append('%s=%s' % (key, log_value))