Changeset 12194

Timestamp:

11 Dec 2014, 08:12:31 (10 years ago)

Author:

Henrik Bettermann

Message:

Fix handle_product_remove. The attribute is meanwhile called product_object.

Add handle_document_removed with test.

Location:

main/waeup.ikoba/trunk/src/waeup/ikoba

Files:

• customers/documents.py (modified) (2 diffs)
• customers/tests/test_catalog.py (modified) (5 diffs)
• products/product.py (modified) (1 diff)

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/documents.py

@@ -25 +25 @@
 from zope.component.interfaces import IFactory
 from zope.interface import implementedBy
+from zope.event import notify
 
 from waeup.ikoba.image import IkobaImageFile
@@ -321 +322 @@
             file_obj.filename, file_obj.data)
 
+
+@grok.subscribe(ICustomerDocument, grok.IObjectRemovedEvent)
+def handle_document_removed(document, event):
+    """If a document is deleted, we make sure that also referrers to
+    customer contract objects are removed.
+    """
+    docid = document.document_id
+
+    # Find all customer contracts that refer to given document...
+    try:
+        contracts = document.customer['contracts'].values()
+    except AttributeError:
+        # customer not available. This might happen during tests.
+        return
+    for contract in contracts:
+        # Remove that referrer...
+        #contract.product = None
+        for key, value in contract.__dict__.items():
+            if key.endswith('_object') and \
+                getattr(value, 'document_id', None) == docid:
+                setattr(contract, key, None)
+                notify(grok.ObjectModifiedEvent(contract))
+                contract.customer.__parent__.logger.info(
+                    'ObjectRemovedEvent - %s - %s - removed: %s' % (
+                        contract.customer.customer_id,
+                        contract.contract_id,
+                        document.document_id))
+    return
+

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/tests/test_catalog.py

@@ -24 +24 @@
 from zope.component import queryUtility, createObject
 from zope.component.hooks import setSite
+from hurry.workflow.interfaces import IWorkflowState
 from waeup.ikoba.app import Company
+from waeup.ikoba.interfaces import VERIFIED
 from waeup.ikoba.testing import FunctionalLayer, FunctionalTestCase
 from waeup.ikoba.customers.customer import Customer
@@ -66 +68 @@
         self.product = self.app['products'][self.product_id]
 
+        document = createObject('waeup.CustomerSampleDocument')
+        document.title = u'My Samle Document'
+        IWorkflowState(document).setState(VERIFIED)
+        self.customer['documents'].addDocument(document)
+        self.document_id = document.document_id
+        self.document = self.customer['documents'][self.document_id]
+
         contract = createObject('waeup.SampleContract')
         contract.title = u'My Samle Contract'
-        contract.product = product
+        contract.product_object = product
+        contract.document_object = document
         contract.last_product_id = product.product_id
         self.customer['contracts'].addContract(contract)
         self.contract_id = contract.contract_id
         self.contract = self.customer['contracts'][self.contract_id]
-
-        document = createObject('waeup.CustomerSampleDocument')
-        document.title = u'My Samle Document'
-        self.customer['documents'].addDocument(document)
-        self.document_id = document.document_id
-        self.document = self.customer['documents'][self.document_id]
 
         return
@@ -167 +171 @@
         assert len(results) == 1
         assert results[0] is self.customer['contracts'][self.contract_id]
-        assert results[0].product is self.product
+        assert results[0].product_object is self.product
 
     def test_product_removal(self):
         # This test does not only test catalog components, it also ensures
-        # that the product attribute of an contract is cleared
+        # that the product object attribute of a contract is cleared
         # but the last_product_id is not.
         del self.app['products'][self.product_id]
-        self.assertTrue(self.contract.product is None)
+        self.assertTrue(self.contract.product_object is None)
         self.assertEqual(self.contract.last_product_id, 'SAM')
         cat = queryUtility(ICatalog, name='contracts_catalog')
@@ -181 +185 @@
         assert len(results) == 1
         assert results[0] is self.customer['contracts'][self.contract_id]
-        assert results[0].product is None
+        assert results[0].product_object is None
         # Product removal is being logged in customers.log
         logfile = os.path.join(
@@ -190 +194 @@
             in logcontent)
 
+    def test_document_removal(self):
+        # Actually, this test does not test catalog components at all.
+        # Tt only ensures that the document object attributes of a contract
+        # are cleared, like in the test_product_removal above.
+        del self.customer['documents'][self.document_id]
+        self.assertTrue(self.contract.document_object is None)
+        # Document removal is being logged in customers.log
+        logfile = os.path.join(
+            self.app['datacenter'].storage, 'logs', 'customers.log')
+        logcontent = open(logfile).read()
+        self.assertTrue(
+            'INFO - system - ObjectRemovedEvent - K1000000 - c101 - removed: d101\n'
+            in logcontent)
+

main/waeup.ikoba/trunk/src/waeup/ikoba/products/product.py

@@ -79 +79 @@
     for contract in results:
         # Remove that referrer...
-        contract.product = None
+        contract.product_object = None
         notify(grok.ObjectModifiedEvent(contract))
         contract.customer.__parent__.logger.info(