Changeset 12168 for main/waeup.ikoba/trunk/src/waeup/ikoba/documents

Timestamp:

8 Dec 2014, 06:17:30 (10 years ago)

Author:

Henrik Bettermann

Message:

Documents can't be verified without file(s) attached.

Let is_approvable and is_verifiable be more verbose.

Location:

main/waeup.ikoba/trunk/src/waeup/ikoba/documents

Files:

• document.py (modified) (1 diff)
• interfaces.py (modified) (1 diff)
• workflow.py (modified) (2 diffs)

main/waeup.ikoba/trunk/src/waeup/ikoba/documents/document.py

@@ -87 +87 @@
         return
 
+    @property
+    def is_verifiable(self):
+        return True, None
+
     def setMD5(self):
         """Determine md5 checksum of all files and store checksums as

main/waeup.ikoba/trunk/src/waeup/ikoba/documents/interfaces.py

@@ -53 +53 @@
     user_id = Attribute('Id of a user')
     connected_files = Attribute('Names of files connected to a document')
+    is_verifiable = Attribute('Contract verifiable by officer')
 
     title = schema.TextLine(

main/waeup.ikoba/trunk/src/waeup/ikoba/documents/workflow.py

@@ -22 +22 @@
 from zope.component import getUtility
 from hurry.workflow.workflow import Transition, WorkflowState, NullCondition
-from hurry.workflow.interfaces import IWorkflowState, IWorkflowTransitionEvent
+from hurry.workflow.interfaces import (
+    IWorkflowState, IWorkflowTransitionEvent, InvalidTransitionError)
 from waeup.ikoba.interfaces import (
     IObjectHistory, IIkobaWorkflowInfo,
@@ -128 +129 @@
     """Append message to document history and log file and update
     last_transition_date when transition happened.
+
+    Undo the verification of document and raise an exception if document
+    does not meet the requirements for verification.
     """
+    if event.transition.destination == VERIFIED:
+        verifiable, error = obj.is_verifiable
+        if not verifiable:
+            # Undo transition and raise an exception.
+            IWorkflowState(obj).setState(event.transition.source)
+            raise InvalidTransitionError(error)
     if event.transition.transition_id == 'verify':
         obj.setMD5()