Changeset 12122

Timestamp:

3 Dec 2014, 06:43:26 (10 years ago)

Author:

Henrik Bettermann

Message:

Do only provide invitation letter if physical_clearance_date is set and student is in state 'clearance requested'.

Location:

main/waeup.uniben/trunk/src/waeup/uniben/students

Files:

• browser.py (modified) (1 diff)
• tests/test_browser.py (modified) (1 diff)
• viewlets.py (modified) (1 diff)

main/waeup.uniben/trunk/src/waeup/uniben/students/browser.py

@@ -163 +163 @@
         return
 
+
+    def update(self):
+        if self.context.student.state != REQUESTED \
+            or not  self.context.student.physical_clearance_date:
+            self.flash(_('Forbidden'), type="warning")
+            self.redirect(self.url(self.context))
+
     def render(self):
         studentview = StudentBasePDFFormPage(self.context.student,

main/waeup.uniben/trunk/src/waeup/uniben/students/tests/test_browser.py

@@ -171 +171 @@
             attr="secr_cults.jpg")
         file_store.createFile(file_id, StringIO(secr_cults))
+        # Clearance invitation letter is not yet available
+        self.browser.open(self.clearance_path)
+        self.assertFalse('invitation slip' in self.browser.contents)
+        self.browser.open(self.student_path + '/clearance_invitation_slip.pdf')
+        self.assertTrue('Forbidden' in self.browser.contents)
         self.browser.open(self.edit_clearance_path)
         self.browser.getControl("Save and request clearance").click()
-
         self.assertTrue('Clearance has been requested'
             in self.browser.contents)
-        # Student can export physical_clearance.slip
+        # Now student can export physical_clearance.slip
         self.app['configuration'].name = u'University of Benin'
         self.student.physical_clearance_date = u'January 5th, 2015'

main/waeup.uniben/trunk/src/waeup/uniben/students/viewlets.py

@@ -67 +67 @@
     text = _('Download clearance invitation slip')
     target = 'clearance_invitation_slip.pdf'
+
+    @property
+    def target_url(self):
+        if self.context.student.state == REQUESTED \
+            and self.context.student.physical_clearance_date:
+            return self.view.url(self.view.context, self.target)
+        return False