Changeset 12103

Timestamp:

1 Dec 2014, 09:59:14 (10 years ago)

Author:

Henrik Bettermann

Message:

Add sample contract interfaces with additional document field. Use these interfaces in form pages.

Location:

main/waeup.ikoba/trunk/src/waeup/ikoba/customers

Files:

• browser.py (modified) (4 diffs)
• contracts.py (modified) (3 diffs)
• interfaces.py (modified) (3 diffs)
• tests/test_browser.py (modified) (6 diffs)

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/browser.py

@@ -51 +51 @@
     ICustomer, ICustomersContainer, ICustomerRequestPW, ICustomersUtils,
     ICustomerDocument, ICustomerDocumentsContainer, ICustomerCreate,
-    ICustomerPDFDocument, IContractsContainer, IContract, IContractEdit
+    ICustomerPDFDocument, IContractsContainer, IContract, IContractEdit,
+    ISampleContract,
     )
 from waeup.ikoba.customers.catalog import search
@@ -1150 +1151 @@
     grok.require('waeup.viewCustomer')
     grok.template('contractpage')
-    form_fields = grok.AutoFields(IContract).omit('last_transition_date')
-    pnav = 4
+    pnav = 4
+
+    @property
+    def form_fields(self):
+        return grok.AutoFields(self.context.form_fields_interface).omit(
+            'last_transition_date')
 
     @property
@@ -1165 +1170 @@
     grok.require('waeup.manageCustomer')
     grok.template('contracteditpage')
-    form_fields = grok.AutoFields(IContract).omit('last_transition_date')
     pnav = 4
     deletion_warning = _('Are you sure?')
+
+    @property
+    def form_fields(self):
+        return grok.AutoFields(self.context.form_fields_interface).omit(
+            'last_transition_date')
 
     @property
@@ -1184 +1193 @@
     grok.name('edit')
     grok.require('waeup.handleCustomer')
-    form_fields = grok.AutoFields(IContractEdit).omit('last_transition_date')
+
+    @property
+    def form_fields(self):
+        return grok.AutoFields(self.context.edit_form_fields_interface).omit(
+            'last_transition_date')
 
     def update(self):

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/contracts.py

@@ -30 +30 @@
     IContractsContainer, ICustomerNavigation,
     IContract, IContractEdit, ICustomersUtils,
-    )
+    ISampleContract, ISampleContractEdit)
 from waeup.ikoba.customers.utils import generate_contract_id
 from waeup.ikoba.utils.helpers import attrs_to_fields
@@ -64 +64 @@
 
     contract_category = None
+
+    form_fields_interface = None
+
+    edit_form_fields_interface = None
 
     def __init__(self):
@@ -142 +146 @@
     """
 
+    grok.implements(ISampleContract, ISampleContractEdit, ICustomerNavigation)
+
     contract_category = 'sample'
+
+    form_fields_interface = ISampleContract
+
+    edit_form_fields_interface = ISampleContractEdit
 
 SampleContract = attrs_to_fields(SampleContract)

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/interfaces.py

@@ -29 +29 @@
 
 from waeup.ikoba.customers.vocabularies import (
-    contextual_reg_num_source, GenderSource, nats_vocab, ConCatProductSource)
+    contextual_reg_num_source, GenderSource, nats_vocab,
+    ConCatProductSource, CustomerDocumentSource)
 
 
@@ -293 +294 @@
         )
 
+
 class IContractEdit(IContract):
     """Interface for editing contract data by customers.
@@ -303 +305 @@
         required = True,
         )
+
+
+class ISampleContract(IContract):
+    """A customer contract sample with document attached.
+
+    """
+
+    document = schema.Choice(
+        title = _(u'Document'),
+        source = CustomerDocumentSource(),
+        required = False,
+        )
+
+
+class ISampleContractEdit(ISampleContract):
+    """Interface for editing sample contract data by customers.
+
+    """
+
+    product = schema.Choice(
+        title = _(u'Product'),
+        source = ConCatProductSource(),
+        required = True,
+        )
+
+    document = schema.Choice(
+        title = _(u'Document'),
+        source = CustomerDocumentSource(),
+        required = True,
+        )

main/waeup.ikoba/trunk/src/waeup/ikoba/customers/tests/test_browser.py

@@ -40 +40 @@
 from waeup.ikoba.customers.interfaces import ICustomersUtils
 from waeup.ikoba.customers.customer import Customer
-from waeup.ikoba.interfaces import IUserAccount, IJobManager, APPROVED
+from waeup.ikoba.interfaces import (
+    IUserAccount, IJobManager, APPROVED, SUBMITTED)
 from waeup.ikoba.authentication import LocalRoleSetEvent
 from waeup.ikoba.tests.test_async import FunctionalAsyncTestCase
@@ -111 +112 @@
         self.customer_id = customer.customer_id
         self.customer = self.app['customers'][self.customer_id]
-        document = createObject('waeup.CustomerSampleDocument')
-        document.title = u'My first document'
-        self.customer['documents'].addDocument(document)
-        contract = createObject('waeup.SampleContract')
-        contract.title = u'My first contract'
-        self.customer['contracts'].addContract(contract)
+        self.document = createObject('waeup.CustomerSampleDocument')
+        self.document.title = u'My first document'
+        self.customer['documents'].addDocument(self.document)
+        self.contract = createObject('waeup.SampleContract')
+        self.contract.title = u'My first contract'
+        self.customer['contracts'].addContract(self.contract)
 
         # Set password
@@ -1074 +1075 @@
         self.browser.getLink("Manage").click()
         self.browser.getControl(name="form.product").value = ['SAM']
-        self.browser.getControl(name="form.title").value = 'My second app'
+        self.browser.getControl(name="form.title").value = 'My second contract'
         self.browser.getControl("Save").click()
         self.assertTrue('Form has been saved.' in self.browser.contents)
@@ -1140 +1141 @@
         IWorkflowState(self.customer).setState(APPROVED)
         self.browser.open(self.contracts_path + '/c102/edit')
-        self.browser.getControl(name="form.title").value = 'My second app'
+        self.browser.getControl(name="form.title").value = 'My second contract'
         # SAM is in the correct contract_category ...
         self.assertTrue('<option value="SAM">' in self.browser.contents)
@@ -1149 +1150 @@
         self.browser.getControl(name="form.product").value = ['SAM']
         self.browser.getControl("Save").click()
-        # After saving the form, last_product_id is set.
+        # Document is a required field on edit form page.
+        self.assertTrue('Document: <span class="error">Required input is missing.</span>'
+            in self.browser.contents)
+        # But our document can't be selected because it's not submitted
+        self.assertFalse('My first document' in self.browser.contents)
+        IWorkflowState(self.document).setState(SUBMITTED)
+        self.browser.open(self.contracts_path + '/c102/edit')
+        self.browser.getControl(name="form.product").value = ['SAM']
+        self.browser.getControl(name="form.document").value = ['d101']
+        self.browser.getControl(name="form.title").value = 'My second contract'
+        self.browser.getControl("Save").click()
+        # After saving the form, last_product_id and other attributes are set
+        self.assertTrue('Form has been saved.' in self.browser.contents)
         self.assertEqual(self.customer['contracts']['c102'].last_product_id, 'SAM')
-        self.assertTrue('Form has been saved.' in self.browser.contents)
+        self.assertEqual(contract.title, 'My second contract')
+        self.assertEqual(contract.product, self.product)
+        self.assertEqual(contract.document, self.document)
         # Saving the form again does not unset last_product_id
-        self.assertEqual(contract.title, 'My second app')
+        self.browser.getControl(name="form.title").value = 'My third contract'
         self.browser.getControl("Save").click()
         self.assertEqual(self.customer['contracts']['c102'].last_product_id, 'SAM')
@@ -1161 +1176 @@
         # Customer can submit the form. The form is also saved.
         self.browser.getLink("Edit").click()
-        self.browser.getControl(name="form.title").value = 'My third app'
+        self.browser.getControl(name="form.title").value = 'My fourth contract'
         self.browser.getControl("Apply now").click()
-        self.assertEqual(contract.title, 'My third app')
+        self.assertEqual(contract.title, 'My fourth contract')
         self.assertEqual(contract.state, 'submitted')
         self.assertTrue('Contract State: submitted for approval' in self.browser.contents)