Changeset 11862

Timestamp:

21 Oct 2014, 07:07:04 (10 years ago)

Author:

Henrik Bettermann

Message:

Add permission, page and button to mass-clear all students in a department.

Location:

main/waeup.kofa/trunk

Files:

• CHANGES.txt (modified) (1 diff)
• src/waeup/kofa/browser/viewlets.py (modified) (1 diff)
• src/waeup/kofa/permissions.py (modified) (6 diffs)
• src/waeup/kofa/students/browser.py (modified) (1 diff)
• src/waeup/kofa/students/tests/test_browser.py (modified) (6 diffs)

main/waeup.kofa/trunk/CHANGES.txt

@@ -4 +4 @@
 1.3dev (unreleased)
 ===================
+
+* Add permission, page and button to mass-clear all students in a department.
 
 * Hide export download button 24 hours after file generation.

main/waeup.kofa/trunk/src/waeup/kofa/browser/viewlets.py

@@ -476 +476 @@
     grok.order(3)
 
+class ClearDepartmentStudentsActionButton(ManageActionButton):
+    """ 'Clear all students' button for departments.
+    """
+    grok.context(IDepartment)
+    grok.view(DepartmentPage)
+    grok.name('cleardepartmentstudents')
+    grok.require('waeup.clearAllStudents')
+    icon = 'actionicon_accept.png'
+    text = _('Clear all students')
+    target = 'clearallstudents'
+    grok.order(4)
+
+    @property
+    def onclick(self):
+        return "return window.confirm(%s);" % _(
+            "'All students, who requested clearance in this department, will be cleared. Are you sure?'")
+
 class ManageCourseActionButton(ManageActionButton):
     """ 'Edit settings' button for courses.

main/waeup.kofa/trunk/src/waeup/kofa/permissions.py

@@ -59 +59 @@
     grok.name('waeup.showStudents')
 
+class ClearAllStudents(grok.Permission):
+    grok.name('waeup.clearAllStudents')
+
 class EditScores(grok.Permission):
     grok.name('waeup.editScores')
@@ -128 +131 @@
     grok.permissions('waeup.showStudents',
                      'waeup.viewAcademics',
-                     'waeup.exportData')
+                     'waeup.exportData',
+                     'waeup.clearAllStudents')
 
 class LocalStudentsManager(grok.Role):
@@ -158 +162 @@
     grok.permissions('waeup.showStudents',
                      'waeup.viewAcademics',
-                     'waeup.exportData')
+                     'waeup.exportData',
+                     'waeup.clearAllStudents')
 
 class PGClearanceOfficer(grok.Role):
@@ -168 +173 @@
     grok.permissions('waeup.showStudents',
                      'waeup.viewAcademics',
-                     'waeup.exportData')
+                     'waeup.exportData',
+                     'waeup.clearAllStudents')
 
 class CourseAdviser100(grok.Role):
@@ -336 +342 @@
                      'waeup.clearStudent', 'waeup.payStudent',
                      'waeup.uploadStudentFile', 'waeup.showStudents',
+                     'waeup.clearAllStudents',
                      'waeup.editScores',
                      'waeup.triggerTransition',
@@ -369 +376 @@
                      'waeup.clearStudent', 'waeup.payStudent',
                      'waeup.uploadStudentFile', 'waeup.showStudents',
+                     'waeup.clearAllStudents',
                      'waeup.editScores',
                      #'waeup.triggerTransition',

main/waeup.kofa/trunk/src/waeup/kofa/students/browser.py

@@ -3004 +3004 @@
         return list(set(hitlist))
 
+class ClearAllStudentsInDepartmentPage(UtilityView, grok.View):
+    """ Clear all students of a department in state 'clearance requested'.
+    """
+    grok.context(IDepartment)
+    grok.name('clearallstudents')
+    grok.require('waeup.clearAllStudents')
+
+    def update(self):
+        cat = queryUtility(ICatalog, name='students_catalog')
+        students = cat.searchResults(
+            depcode=(self.context.code, self.context.code),
+            state=(REQUESTED, REQUESTED)
+            )
+        num = 0
+        for student in students:
+            if getUtility(IStudentsUtils).clearance_disabled_message(student):
+                continue
+            IWorkflowInfo(student).fireTransition('clear')
+            num += 1
+        self.flash(_('%d students have been cleared.' % num))
+        self.redirect(self.url(self.context))
+        return
+
+    def render(self):
+        return
+
+
 class EditScoresPage(KofaPage):
     """Page that filters and lists students.

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_browser.py

@@ -1384 +1384 @@
         return
 
-    def test_handle_clearance_by_co(self):
+    def init_clearance_officer(self):
         # Create clearance officer
         self.app['users'].addUser('mrclear', 'mrclearsecret')
@@ -1394 +1394 @@
         #prmglobal.assignRoleToPrincipal('waeup.StudentsOfficer', 'mrclear')
         # Assign local ClearanceOfficer role
-        department = self.app['faculties']['fac1']['dep1']
-        prmlocal = IPrincipalRoleManager(department)
+        self.department = self.app['faculties']['fac1']['dep1']
+        prmlocal = IPrincipalRoleManager(self.department)
         prmlocal.assignRoleToPrincipal('waeup.local.ClearanceOfficer', 'mrclear')
         IWorkflowState(self.student).setState('clearance started')
+        # Add another student for testing
+        other_student = Student()
+        other_student.firstname = u'Dep2'
+        other_student.lastname = u'Student'
+        self.app['students'].addStudent(other_student)
+        self.other_student_path = (
+            'http://localhost/app/students/%s' % other_student.student_id)
         # Login as clearance officer
         self.browser.open(self.login_path)
@@ -1403 +1410 @@
         self.browser.getControl(name="form.password").value = 'mrclearsecret'
         self.browser.getControl("Login").click()
+
+    def test_handle_clearance_by_co(self):
+        self.init_clearance_officer()
         self.assertMatches('...You logged in...', self.browser.contents)
         # CO is landing on index page
@@ -1419 +1429 @@
         # has changed
         notify(LocalRoleSetEvent(
-            department, 'waeup.local.ClearanceOfficer', 'mrclear', granted=True))
+            self.department, 'waeup.local.ClearanceOfficer', 'mrclear', granted=True))
         self.browser.open('http://localhost/app/users/mrclear/my_roles')
         self.assertTrue('Clearance Officer' in self.browser.contents)
@@ -1430 +1440 @@
         self.assertEqual(self.browser.url, self.clearance_path)
         # ... but not other students
-        other_student = Student()
-        other_student.firstname = u'Dep2'
-        other_student.lastname = u'Student'
-        self.app['students'].addStudent(other_student)
-        other_student_path = (
-            'http://localhost/app/students/%s' % other_student.student_id)
         self.assertRaises(
-            Unauthorized, self.browser.open, other_student_path)
+            Unauthorized, self.browser.open, self.other_student_path)
         # Clearance is disabled for this session
         self.browser.open(self.clearance_path)
@@ -1536 +1540 @@
         IWorkflowInfo(self.student).fireTransition('clear')
         self.assertEqual(self.student.officer_comment, None)
+        return
+
+    def test_handle_mass_clearance_by_co(self):
+        self.init_clearance_officer()
+        # Additional setups according to test above
+        notify(LocalRoleSetEvent(
+            self.department, 'waeup.local.ClearanceOfficer', 'mrclear', granted=True))
+        self.app['configuration']['2004'].clearance_enabled = True
+        IWorkflowState(self.student).setState('clearance requested')
+        # Update the catalog
+        notify(grok.ObjectModifiedEvent(self.student))
+        # The CO can go to the department and clear all students in department
+        self.browser.open('http://localhost/app/faculties/fac1/dep1')
+        self.browser.getLink("Clear all students").click()
+        self.assertTrue('1 students have been cleared' in self.browser.contents)
+        self.browser.open(self.history_path)
+        self.assertTrue('Cleared by Carlo Pitter' in self.browser.contents)
+        logfile = os.path.join(
+            self.app['datacenter'].storage, 'logs', 'students.log')
+        logcontent = open(logfile).read()
+        self.assertTrue(
+            'INFO - mrclear - K1000000 - Cleared' in logcontent)
+        self.browser.open('http://localhost/app/faculties/fac1/dep1')
+        self.browser.getLink("Clear all students").click()
+        self.assertTrue('0 students have been cleared' in self.browser.contents)
+        return
 
     def test_handle_courses_by_ca(self):