Changeset 11652

Timestamp:

14 May 2014, 16:04:54 (11 years ago)

Author:

Henrik Bettermann

Message:

Let CustomPaymentDataWebservice? distinguish between old and new student school fee payments.

Location:

main/waeup.aaue/trunk

Files:

• CHANGES.txt (modified) (1 diff)
• src/waeup/aaue/etranzact/browser.py (modified) (4 diffs)
• src/waeup/aaue/etranzact/tests.py (modified) (3 diffs)

main/waeup.aaue/trunk/CHANGES.txt

@@ -4 +4 @@
 1.2dev (unreleased)
 ===================
+
+* Let CustomPaymentDataWebservice distinguish between old and new student
+  school fee payments.
 
 * To guarantee that cleared students pay both acceptance fee and school fees,

main/waeup.aaue/trunk/src/waeup/aaue/etranzact/browser.py

@@ -84 +84 @@
                 self.output = ERROR_PART1 + 'Wrong IP address' + ERROR_PART2
                 return
-        if PAYMENT_TYPE not in ('SCHOOL-FEE', 'ACCEPTANCE-FEE', 'APPLICATION-FEE'):
+        if PAYMENT_TYPE not in ('SCHOOL-FEE-RETURNING', 'SCHOOL-FEE-NEW',
+            'ACCEPTANCE-FEE', 'APPLICATION-FEE'):
             self.output = ERROR_PART1 + 'Invalid PAYMENT_TYPE' + ERROR_PART2
             return
@@ -105 +106 @@
             self.output = ERROR_PART1 + 'Invalid PAYEE_ID' + ERROR_PART2
             return
+        student = results[0].student
         amount = results[0].amount_auth
         payment_type = results[0].category
@@ -114 +116 @@
             self.output = ERROR_PART1 + 'PAYEE_ID already used' + ERROR_PART2
             return
-        if PAYMENT_TYPE == 'SCHOOL-FEE' \
-            and not results[0].p_category.startswith('schoolfee'):
-            self.output = ERROR_PART1 + 'Wrong PAYMENT_TYPE' + ERROR_PART2
-            return
+        if PAYMENT_TYPE.startswith('SCHOOL-FEE'):
+            if not results[0].p_category.startswith('schoolfee'):
+                self.output = ERROR_PART1 + 'Wrong PAYMENT_TYPE' + ERROR_PART2
+                return
+            if PAYMENT_TYPE == 'SCHOOL-FEE-RETURNING' and student.state == CLEARED:
+                self.output = ERROR_PART1 + 'Wrong PAYMENT_TYPE' + ERROR_PART2
+                return
+            if PAYMENT_TYPE == 'SCHOOL-FEE-NEW' and student.state != CLEARED:
+                self.output = ERROR_PART1 + 'Wrong PAYMENT_TYPE' + ERROR_PART2
+                return
         if PAYMENT_TYPE == 'ACCEPTANCE-FEE' \
             and not results[0].p_category == 'clearance':
@@ -140 +148 @@
             return
         self.output = (
-            # Version 1
-            #'FULL_NAME=%s&' +
-            #'FACULTY=%s&' +
-            #'DEPARTMENT=%s&' +
-            #'RETURN_TYPE=%s&' +
-            #'PROGRAMME_TYPE=%s&' +
-            #'PAYMENT_TYPE=%s&' +
-            #'ACADEMIC_SESSION=%s&' +
-            #'MATRIC_NO=%s&' +
-            #'FEE_AMOUNT=%s&' +
-            #'TRANSACTION_STATUS=%s'
-
-            # Version 2
             'PayeeName=%s~' +
             'Faculty=%s~' +

main/waeup.aaue/trunk/src/waeup/aaue/etranzact/tests.py

@@ -84 +84 @@
     def test_webservice(self):
         self.browser.open(
-            'http://localhost/app/feerequest?PAYEE_ID=%s&PAYMENT_TYPE=SCHOOL-FEE'
+            'http://localhost/app/feerequest?PAYEE_ID=%s&PAYMENT_TYPE=SCHOOL-FEE-NEW'
             % self.p_id)
         self.assertEqual(self.browser.contents,
-            # Version 1
-            #'FULL_NAME=Anna Tester&'
-            #'FACULTY=fac1&'
-            #'DEPARTMENT=dep1&'
-            #'RETURN_TYPE=%s&'
-            #'PROGRAMME_TYPE=CERT1&'
-            #'PAYMENT_TYPE=School Fee&'
-            #'ACADEMIC_SESSION=2004/2005&'
-            #'MATRIC_NO=E1000000&'
-            #'FEE_AMOUNT=1234.0&'
-            #'TRANSACTION_STATUS=unpaid'
-
-            # Version 2
             'PayeeName=Anna Tester~'
             'Faculty=fac1~'
@@ -121 +108 @@
         self.assertEqual(self.browser.contents, ERROR_PART1 + 'Missing PAYEE_ID' + ERROR_PART2)
         self.browser.open(
-            'http://localhost/app/feerequest?PAYEE_ID=nonsense&PAYMENT_TYPE=SCHOOL-FEE')
+            'http://localhost/app/feerequest?PAYEE_ID=nonsense&PAYMENT_TYPE=SCHOOL-FEE-NEW')
         self.assertEqual(self.browser.contents, ERROR_PART1 + 'Invalid PAYEE_ID' + ERROR_PART2)
         self.browser.open(
@@ -141 +128 @@
         self.student['payments'][self.p_id].p_state = 'paid'
         self.browser.open(
-            'http://localhost/app/feerequest?PAYEE_ID=%s&PAYMENT_TYPE=SCHOOL-FEE'
+            'http://localhost/app/feerequest?PAYEE_ID=%s&PAYMENT_TYPE=SCHOOL-FEE-NEW'
             % self.p_id)
         self.assertEqual(self.browser.contents, ERROR_PART1 + 'PAYEE_ID already used' + ERROR_PART2)
 
+        IWorkflowState(self.student).setState('returning')
+        self.student['payments'][self.p_id].p_state = 'unpaid'
+        self.browser.open(
+            'http://localhost/app/feerequest?PAYEE_ID=%s&PAYMENT_TYPE=SCHOOL-FEE-NEW'
+            % self.p_id)
+        self.assertEqual(self.browser.contents, ERROR_PART1 + 'Wrong PAYMENT_TYPE' + ERROR_PART2)
+        self.browser.open(
+            'http://localhost/app/feerequest?PAYEE_ID=%s&PAYMENT_TYPE=SCHOOL-FEE-RETURNING'
+            % self.p_id)
+
+        self.assertEqual(self.browser.contents,
+            'PayeeName=Anna Tester~'
+            'Faculty=fac1~'
+            'Department=dep1~'
+            'Level=100~'
+            'ProgrammeType=CERT1~'
+            'StudyType=ug_ft~'
+            'Session=2004/2005~'
+            'PayeeID=%s~'
+            'Amount=1234.0~'
+            'FeeStatus=unpaid~'
+            'Semester=N/A~'
+            'PaymentType=School Fee~'
+            'MatricNumber=E1000000~'
+            'Email=aa@aa.ng~'
+            'PhoneNumber=1234' % self.p_id)
 
     @external_test