Changeset 11646 for main/waeup.kwarapoly/trunk

Timestamp:

14 May 2014, 05:17:40 (10 years ago)

Author:

Henrik Bettermann

Message:

Use init_update and samePaymentMade methods.

Location:

main/waeup.kwarapoly/trunk

Files:

• CHANGES.txt (modified) (1 diff)
• src/waeup/kwarapoly/interswitch/browser.py (modified) (1 diff)
• src/waeup/kwarapoly/students/utils.py (modified) (1 diff)

main/waeup.kwarapoly/trunk/CHANGES.txt

@@ -4 +4 @@
 1.2dev (unreleased)
 ===================
+
+* Use init_update and samePaymentMade methods.
 
 * Use base classes InterswitchPageApplicant and InterswitchPageStudent from

main/waeup.kwarapoly/trunk/src/waeup/kwarapoly/interswitch/browser.py

@@ -67 +67 @@
 
     def update(self):
-        student, certificate, xmldict = super(
-            CustomInterswitchPageStudent, self).update()
+        error = self.init_update()
+        if error:
+            self.flash(error, type='danger')
+            self.redirect(self.url(self.context, '@@index'))
+            return
+        student = self.student
+        xmldict = self.xmldict
         # Provider data
         xmldict['detail_ref'] = self.context.p_id

main/waeup.kwarapoly/trunk/src/waeup/kwarapoly/students/utils.py

@@ -251 +251 @@
         if amount in (0.0, None):
             return _(u'Amount could not be determined.'), None
-        for key in student['payments'].keys():
-            ticket = student['payments'][key]
-            if ticket.p_state == 'paid' and\
-               ticket.p_category == category and \
-               ticket.p_item == p_item and \
-               ticket.p_session == p_session:
-                  return _('This type of payment has already been made.'), None
+        if self.samePaymentMade(student, category, p_item, p_session):
+            return _('This type of payment has already been made.'), None
         # Add session specific penalty fee.
         if category == 'schoolfee' and student.is_postgrad: