Changeset 11570 for main/waeup.kofa/trunk/src/waeup/kofa/students

Timestamp:

3 Apr 2014, 12:53:11 (11 years ago)

Author:

Henrik Bettermann

Message:

We do no longer need the success return value.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/students

Files:

• browser.py (modified) (1 diff)
• payments.py (modified) (3 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/students/browser.py

@@ -1856 +1856 @@
 
     def update(self):
-        success, msg, log = self.context.approveStudentPayment()
+        msg, log = self.context.approveStudentPayment()
         if log is not None:
             # Add log message to students.log

main/waeup.kofa/trunk/src/waeup/kofa/students/payments.py

@@ -107 +107 @@
             error = self._createActivationCodes()
             if error is not None:
-                return False, error, error
+                return error, error
         log = 'successful %s payment: %s' % (self.p_category, self.p_id)
         msg = _('Successful payment')
-        return True, msg, log
+        return msg, log
 
     def doAfterStudentPaymentApproval(self):
@@ -118 +118 @@
             error = self._createActivationCodes()
             if error is not None:
-                return False, error, error
+                return error, error
         log = '%s payment approved: %s' % (self.p_category, self.p_id)
         msg = _('Payment approved')
-        return True, msg, log
+        return msg, log
 
     def approveStudentPayment(self):
@@ -127 +127 @@
         """
         if self.p_state == 'paid':
-            return False, _('This ticket has already been paid.'), None
+            return _('This ticket has already been paid.'), None
         self.approve()
         return self.doAfterStudentPaymentApproval()