Changeset 10675 for main/waeup.kwarapoly/trunk/src/waeup

Timestamp:

30 Oct 2013, 19:43:48 (11 years ago)

Author:

Henrik Bettermann

Message:

New students must book and pay for accommodation first, before making school fee payments.

Location:

main/waeup.kwarapoly/trunk/src/waeup/kwarapoly

Files:

• interswitch/tests.py (modified) (5 diffs)
• students/tests/test_browser.py (modified) (3 diffs)
• students/utils.py (modified) (4 diffs)

main/waeup.kwarapoly/trunk/src/waeup/kwarapoly/interswitch/tests.py

@@ -28 +28 @@
 from waeup.kofa.configuration import SessionConfiguration
 from waeup.kwarapoly.testing import FunctionalLayer
+from waeup.kwarapoly.students.payments import CustomStudentOnlinePayment
 
 # Also run tests that send requests to external servers?
@@ -76 +77 @@
         notify(grok.ObjectModifiedEvent(self.student))
 
+
+    def test_schoolfee_ticket_creation(self):
         self.browser.addHeader('Authorization', 'Basic mgr:mgrpw')
         self.browser.open(self.payments_path)
@@ -82 +85 @@
         self.browser.getControl(name="form.p_category").value = ['schoolfee']
         self.browser.getControl("Create ticket").click()
+        self.assertMatches('...Book and pay for accommodation first...',
+                           self.browser.contents)
+        # We add a fake maint. payment ticket to meet the condition
+        maint_payment = CustomStudentOnlinePayment()
+        self.student['payments']['any_key'] = maint_payment
+        maint_payment.p_category = 'hostel_maintenance'
+        maint_payment.p_state = 'unpaid'
+        maint_payment.p_session = 2004
+        self.browser.getControl(name="form.p_category").value = ['schoolfee']
+        self.browser.getControl("Create ticket").click()
+        self.assertMatches('...Book and pay for accommodation first...',
+                           self.browser.contents)
+        # Ticket must be paid
+        maint_payment.p_state = 'paid'
+        self.browser.getControl(name="form.p_category").value = ['schoolfee']
+        self.browser.getControl("Create ticket").click()
         self.assertMatches('...ticket created...',
                            self.browser.contents)
         ctrl = self.browser.getControl(name='val_id')
-        self.value = ctrl.options[0]
+        self.value = ctrl.options[1]
         self.browser.getLink(self.value).click()
         self.assertMatches('...Amount Authorized...',
@@ -107 +126 @@
 
     def test_interswitch_form(self):
+
+        self.browser.addHeader('Authorization', 'Basic mgr:mgrpw')
+        self.browser.open(self.payments_path)
+        # In KwaraPoly only returning students can create school fee payment
+        # without haveing paid accommodation fee
+        IWorkflowState(self.student).setState('returning')
+        configuration = createObject('waeup.SessionConfiguration')
+        configuration.academic_session = 2005
+        self.app['configuration'].addSessionConfiguration(configuration)
+        self.browser.open(self.payments_path + '/addop')
+        self.browser.getControl(name="form.p_category").value = ['schoolfee']
+        self.browser.getControl("Create ticket").click()
+        self.assertMatches('...ticket created...', self.browser.contents)
+        ctrl = self.browser.getControl(name='val_id')
+        self.value = ctrl.options[0]
+        self.browser.getLink(self.value).click()
+        self.assertMatches('...Amount Authorized...', self.browser.contents)
+        self.assertMatches(
+            '...<span>29500.0</span>...',
+            self.browser.contents)
+        self.payment_url = self.browser.url
+
         # Manager can access InterswitchForm
         self.assertEqual(self.student['payments'][self.value].provider_amt, 0.0)
@@ -119 +160 @@
                            self.browser.contents)
         self.assertTrue(
-            '<input type="hidden" name="amount" value="3940000.0" />' in
-            self.browser.contents)
-        self.assertTrue(
-            'item_name="School Fee" item_amt="3610000" bank_id="120" acct_num="1771180233"' in
+            '<input type="hidden" name="amount" value="2950000.0" />' in
+            self.browser.contents)
+        self.assertTrue(
+            'item_name="School Fee" item_amt="2620000" bank_id="120" acct_num="1771180233"' in
             self.browser.contents)
         self.assertTrue(

main/waeup.kwarapoly/trunk/src/waeup/kwarapoly/students/tests/test_browser.py

@@ -104 +104 @@
         self.browser.getControl(name="form.p_category").value = ['schoolfee']
         self.browser.getControl("Create ticket").click()
+
+        self.assertMatches('...Book and pay for accommodation first...',
+                           self.browser.contents)
+
+        # In KwaraPoly only returning students can create school fee payment
+        # without haveing paid accommodation fee
+        IWorkflowState(self.student).setState('returning')
+        configuration = createObject('waeup.SessionConfiguration')
+        configuration.academic_session = 2005
+        self.app['configuration'].addSessionConfiguration(configuration)
+        self.browser.getControl(name="form.p_category").value = ['schoolfee']
+        self.browser.getControl("Create ticket").click()
         self.assertMatches('...ticket created...',
                            self.browser.contents)
@@ -155 +167 @@
         self.browser.open(self.payments_path + '/addop')
         self.browser.getControl(name="form.p_category").value = ['schoolfee']
-        self.browser.getControl("Create ticket").click()
-        self.assertMatches('...ticket created...',
-                           self.browser.contents)
-        # In state returning we can add a new school fee ticket since
-        # p_session and p_level is different
-        IWorkflowState(self.student).setState('returning')
-        self.browser.open(self.payments_path + '/addop')
-        self.browser.getControl(name="form.p_category").value = ['schoolfee']
-        self.browser.getControl("Create ticket").click()
-        # Uups, we forgot to add a session configuration for next session
-        self.assertTrue('Session configuration object is not available.'
-            in self.browser.contents)
-        configuration = createObject('waeup.SessionConfiguration')
-        configuration.academic_session = 2005
-        self.app['configuration'].addSessionConfiguration(configuration)
         self.browser.getControl("Create ticket").click()
         self.assertMatches('...ticket created...',
@@ -222 +219 @@
         self.assertEqual(pt_ft(self.student), 'ft')
 
+        error, payment = utils.setPaymentDetails('schoolfee',self.student)
+        self.assertEqual(error,
+            'Book and pay for accommodation first before making'
+            ' school fee payments.')
+        # We add a fake maint. payment ticket to meet the condition
+        maint_payment = createObject('waeup.StudentOnlinePayment')
+        self.student['payments']['any_key'] = maint_payment
+        maint_payment.p_category = 'hostel_maintenance'
+        maint_payment.p_state = 'paid'
+        maint_payment.p_session = 2004
         error, payment = utils.setPaymentDetails('schoolfee',self.student)
         self.assertEqual(payment.p_level, 100)

main/waeup.kwarapoly/trunk/src/waeup/kwarapoly/students/utils.py

@@ -20 +20 @@
 from time import time
 from zope.component import createObject, getUtility
+from zope.catalog.interfaces import ICatalog
 from waeup.kofa.interfaces import CLEARED, RETURNING, PAID
 from kofacustom.nigeria.students.utils import NigeriaStudentsUtils
@@ -25 +26 @@
 from waeup.kofa.interfaces import CLEARED, RETURNING, IKofaUtils
 from waeup.kofa.fees import FeeTable
+from waeup.kofa.hostels.hostel import NOT_OCCUPIED
 from waeup.kwarapoly.interfaces import MessageFactory as _
 
@@ -124 +126 @@
         new_session = student['studycourse'].current_session + 1
         return new_session, new_level
+
+    def _maintPaymentMade(self, student, session):
+        if len(student['payments']):
+            for ticket in student['payments'].values():
+                if ticket.p_category == 'hostel_maintenance' and \
+                    ticket.p_session == session and ticket.p_state == 'paid':
+                        return True
+        return False
+
+    def _bedAvailable(self, student):
+        acc_details  = self.getAccommodationDetails(student)
+        cat = getUtility(ICatalog, name='beds_catalog')
+        entries = cat.searchResults(
+            owner=(student.student_id,student.student_id))
+        if len(entries):
+            # Bed has already been booked.
+            return True
+        entries = cat.searchResults(
+            bed_type=(acc_details['bt'],acc_details['bt']))
+        available_beds = [
+            entry for entry in entries if entry.owner == NOT_OCCUPIED]
+        if available_beds:
+            # Bed has not yet been booked but beds are available.
+            return True
+        return False
 
     def setPaymentDetails(self, category, student,
@@ -170 +197 @@
                 if academic_session == None:
                     return _(u'Session configuration object is not available.'), None
+            if student.state == CLEARED:
+                # Fresh students must have booked and paid for accommodation.
+                if self._bedAvailable(student):
+                    if not self._maintPaymentMade(student, p_session):
+                        return _('Book and pay for accommodation first '
+                                 'before making school fee payments.'), None
             if student.state in (RETURNING, CLEARED):
                 if p_level in PAYMENT_LEVELS: