Changeset 10635

Timestamp:

21 Sep 2013, 09:12:09 (11 years ago)

Author:

Henrik Bettermann

Message:

Using attrs_to_fields, which we didn't use in the beginning, makes a lot of problems. Many tests have to be changed and also the batch processor has to be adjusted. Thus it seems to be easier to use to update all department objects with the KofaPluggable? utility.

File:

• main/waeup.kofa/trunk/src/waeup/kofa/university/department.py (modified) (4 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/university/department.py

@@ -23 +23 @@
 from zope.interface import implementedBy
 from zope.component import getUtility
+from zope.schema import getFields
 from waeup.kofa.university.faculty import longtitle
 from waeup.kofa.university.coursescontainer import CoursesContainer
 from waeup.kofa.university.certificatescontainer import CertificatesContainer
 from waeup.kofa.utils.batching import VirtualExportJobContainer
-from waeup.kofa.interfaces import IKofaUtils
+from waeup.kofa.interfaces import IKofaUtils, IKofaPluggable
 from waeup.kofa.utils.helpers import attrs_to_fields
 from waeup.kofa.university.interfaces import IDepartment, IDepartmentAdd
@@ -71 +72 @@
         self.certificates.__parent__ = self
         self.certificates.__name__ = 'certificates'
+        self.score_editing_disabled = False
 
     def traverse(self, name):
@@ -90 +92 @@
         return longtitle(self)
 
-# Set all attributes of Department required in IDepartment as field
-# properties. Doing this, we do not have to set initial attributes
-# ourselves and as a bonus we get free validation when an attribute is
-# set.
-Department = attrs_to_fields(Department)
-
 class DepartmentFactory(grok.GlobalUtility):
     """A factory for department containers.
@@ -111 +107 @@
         """
         return implementedBy(Department)
+
+class DepartmentsPlugin(grok.GlobalUtility):
+    """A plugin that updates courses.
+    """
+
+    grok.implements(IKofaPluggable)
+    grok.name('departments')
+
+    deprecated_attributes = []
+
+    def setup(self, site, name, logger):
+        return
+
+    def update(self, site, name, logger):
+        items = getFields(IDepartment).items()
+        for faculty in site['faculties'].values():
+            for department in faculty.values():
+                # Add new attributes
+                for i in items:
+                    if not hasattr(department,i[0]):
+                        setattr(department,i[0],i[1].missing_value)
+                        logger.info(
+                            'DepartmentsPlugin: %s attribute %s added.' % (
+                            department.code,i[0]))
+                # Remove deprecated attributes
+                for i in self.deprecated_attributes:
+                    try:
+                        delattr(department,i)
+                        logger.info(
+                            'DepartmentsPlugin: %s attribute %s deleted.' % (
+                            department.code,i))
+                    except AttributeError:
+                        pass
+        return