Changeset 10581

Timestamp:

3 Sep 2013, 06:48:26 (11 years ago)

Author:

Henrik Bettermann

Message:

If no credits have been weighted, do not categorize as 'failed'.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/students/reports

Files:

• session_results_presentation.py (modified) (1 diff)
• tests/test_session_results_presentation.py (modified) (1 diff)

main/waeup.kofa/trunk/src/waeup/kofa/students/reports/session_results_presentation.py

@@ -76 +76 @@
                 continue
             if itemcount > 1:
-                # More than one session registered in this session
+                # Error: more than one session registered in this session
                 table[len(students_utils.gpa_boundaries)].append(line)
                 continue
+        if level_obj.gpa_params[1] == 0:
+            # Error: no credits weighted
+            table[len(students_utils.gpa_boundaries)].append(line)
+            continue
+        # Session GPA can be determined
         table[students_utils.getClassFromCGPA(level_obj.gpa)[0]].append(line)
     return table

main/waeup.kofa/trunk/src/waeup/kofa/students/reports/tests/test_session_results_presentation.py

@@ -47 +47 @@
             [[], [], [], [], [], [], [(u'K1000000', u'1234', u'Bob Tester')]])
         return
+
+    def test_get_students_without_scores(self):
+        self.student['studycourse']['100']['Course1'].score = None
+        result = get_students('fac1', 'dep1', 2010)
+        self.assertEqual(result,
+            [[], [], [], [], [], [], [(u'K1000000', u'1234', u'Bob Tester')]])
 
     def test_get_students_without_level_in_session(self):