Changeset 10541

Timestamp:

27 Aug 2013, 20:32:12 (11 years ago)

Author:

Henrik Bettermann

Message:

Reuse code by defining a mixin view.

File:

• main/waeup.kofa/trunk/src/waeup/kofa/browser/pages.py (modified) (9 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/browser/pages.py

@@ -234 +234 @@
     return entries
 
+class LocalRoleAssignmentUtilityView(object):
+    """A view mixin with useful methods for local role assignment.
+
+    """
+
+    def getLocalRoles(self):
+        roles = ILocalRolesAssignable(self.context)
+        return roles()
+
+    def getUsers(self):
+        return get_all_users()
+
+    def getUsersWithLocalRoles(self):
+        return get_users_with_local_roles(self.context)
+
 #
 # Login/logout and language switch pages...
@@ -1773 +1788 @@
         return _('Departments')
 
-class FacultyManageFormPage(KofaEditFormPage):
+class FacultyManageFormPage(KofaEditFormPage,
+                            LocalRoleAssignmentUtilityView):
     """Manage the basic properties of a `Faculty` instance.
     """
@@ -1804 +1820 @@
         return super(FacultyManageFormPage, self).update()
 
-    def getLocalRoles(self):
-        roles = ILocalRolesAssignable(self.context)
-        return roles()
-
-    def getUsers(self):
-        return get_all_users()
-
-    def getUsersWithLocalRoles(self):
-        return get_users_with_local_roles(self.context)
-
     @jsaction(_('Remove selected'))
     def delDepartments(self, **data):
@@ -1908 +1914 @@
             yield(dict(url=url, name=key, container=val))
 
-class DepartmentManageFormPage(KofaEditFormPage):
+class DepartmentManageFormPage(KofaEditFormPage,
+                               LocalRoleAssignmentUtilityView):
     """Manage the basic properties of a `Department` instance.
     """
@@ -1954 +1961 @@
         super(DepartmentManageFormPage, self).update()
         return
-
-    def getLocalRoles(self):
-        roles = ILocalRolesAssignable(self.context)
-        return roles()
-
-    def getUsers(self):
-        return get_all_users()
-
-    def getUsersWithLocalRoles(self):
-        return get_users_with_local_roles(self.context)
 
     @action(_('Save'), style='primary')
@@ -2105 +2102 @@
         return '%s (%s)' % (self.context.title, self.context.code)
 
-class CourseManageFormPage(KofaEditFormPage):
+class CourseManageFormPage(KofaEditFormPage,
+                           LocalRoleAssignmentUtilityView):
     """Edit form page for courses.
     """
@@ -2140 +2138 @@
         return
 
-    def getLocalRoles(self):
-        roles = ILocalRolesAssignable(self.context)
-        return roles()
-
-    def getUsers(self):
-        return get_all_users()
-
-    def getUsersWithLocalRoles(self):
-        return get_users_with_local_roles(self.context)
-
     @action(_('Add local role'), validator=NullValidator)
     def addLocalRole(self, **data):
@@ -2179 +2167 @@
         return super(CertificatePage, self).update()
 
-class CertificateManageFormPage(KofaEditFormPage):
+class CertificateManageFormPage(KofaEditFormPage,
+                                LocalRoleAssignmentUtilityView):
     """Manage the properties of a `Certificate` instance.
     """
@@ -2231 +2220 @@
         self.redirect(self.url(self.context))
         return
-
-    def getLocalRoles(self):
-        roles = ILocalRolesAssignable(self.context)
-        return roles()
-
-    def getUsers(self):
-        return get_all_users()
-
-    def getUsersWithLocalRoles(self):
-        return get_users_with_local_roles(self.context)
 
     @action(_('Add local role'), validator=NullValidator)