Changeset 10539 for main/waeup.kofa

Timestamp:

27 Aug 2013, 19:13:51 (11 years ago)

Author:

Henrik Bettermann

Message:

After some experiments with dynamical roles which allow lecturers to edit the score attribute of course tickets through the UI, I decided to discard the idea completely. It's not feasible and very dangerous to enable lecturers to edit course tickets directly: There are too many course tickets, too many lecturers and to many restrictions. The solution will be that lecturers export the course tickets of their courses, fill the score column and re-upload the csv file. This is still not easy to implement because we can't allow lecturers to access the data center directly. Further discussions are necessary ...

Location:

main/waeup.kofa/trunk/src/waeup/kofa/students

Files:

• studylevel.py (modified) (2 diffs)
• tests/test_browser.py (modified) (1 diff)

main/waeup.kofa/trunk/src/waeup/kofa/students/studylevel.py

@@ -22 +22 @@
 import grok
 from zope.component.interfaces import IFactory
-from zope.component import createObject
+from zope.catalog.interfaces import ICatalog
+from zope.component import createObject, queryUtility
 from zope.interface import implementedBy
 from waeup.kofa.interfaces import academic_sessions_vocab
@@ -270 +271 @@
         return getGradeWeightFromScore(self.score)[1]
 
+    @property
+    def course(self):
+        """Returns the course the ticket is referring to. Returns
+        None if the course has been removed.
+
+        This method is not used in Kofa anymore.
+        """
+        cat = queryUtility(ICatalog, name='courses_catalog')
+        result = cat.searchResults(code=(self.code, self.code))
+        if len(result) != 1:
+            return None
+        return list(result)[0]
+
 CourseTicket = attrs_to_fields(CourseTicket)
 

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_browser.py

@@ -1661 +1661 @@
         self.browser.getControl("Show").click()
         self.assertTrue(self.student_id in self.browser.contents)
-        # XXX: So far the lecturer can neither access ths student ...
+        # The course ticket can be linked with the course.
+        self.assertEqual(
+            self.student['studycourse']['100']['COURSE1'].course,
+            self.course)
+        # Lecturer can neither access ths student ...
         self.assertRaises(
             Unauthorized, self.browser.open, self.student_path)
         # ... nor the respective course ticket since a
-        # CourseTicketPrincipalRoleManager does not yet exist.
+        # editing course tickets by lecturers is not feasible.
+        # Course results must be imported.
         self.assertTrue('COURSE1' in self.student['studycourse']['100'].keys())
         course_ticket_path = self.student_path + '/studycourse/100/COURSE1'