Context navigation

waeup

Timestamp:

4 Jul 2013, 12:52:19 (11 years ago)

Author:

uli

Message:

Handle failed login (with tests).

Location:

main/waeup.cas/trunk/waeup/cas

Files:

-                      r10394
+                      r10397
         service = req.POST.get('service', req.GET.get('service', None))
         service_field = ''
+        msg = ''
         username = req.POST.get('username', None)
         password = req.POST.get('password', None)
 …
         if username and password and valid_lt:
             # act as credentials acceptor
             cred_ok = self.auth.check_credentials(username, password)
+            cred_ok, reason = self.auth.check_credentials(username, password)
             if cred_ok:
                 if service is None:
 …
                     resp.text = html
                     return resp
+            else:
+                # login failed
+                msg = '<i>Login failed</i><br />Reason: %s' % reason
         if service is not None:
             service_field = (
 …
         html = html.replace('LT_VALUE', lt.ticket)
         html = html.replace('SERVICE_FIELD_VALUE', service_field)
+        html = html.replace('MSG_TEXT', msg)
         return Response(html)

-                      r10394
+                      r10397
   </head>
   <body>
+    <div id="msg">
+      MSG_TEXT
+    </div>
     Please enter your credentials to authenticate:
     <form method="post">

-                      r10394
+                      r10397
         assert b'ticket=ST-' in resp.body
+    def test_login_cred_acceptor_failed(self):
+        # 2.2.4: failed login yields a message
+        lt = create_login_ticket()
+        self.raw_app.db.add(lt)
+        lt_string = lt.ticket
+        resp = self.app.post('/login', dict(
+            username='bird', password='cat', lt=lt_string))
+        assert resp.status == '200 OK'
+        assert b'failed' in resp.body
 class CASServerHelperTests(unittest.TestCase):

Note: See TracChangeset for help on using the changeset viewer.