Changeset 10396

Timestamp:

4 Jul 2013, 10:45:39 (11 years ago)

Author:

uli

Message:

Let authtenticators give back a reason if login fails.

Location:

main/waeup.cas/trunk/waeup/cas

Files:

• authenticators.py (modified) (1 diff)
• tests/test_authenticators.py (modified) (1 diff)

main/waeup.cas/trunk/waeup/cas/authenticators.py

@@ -97 +97 @@
 
     def check_credentials(self, username='', password=''):
-        """If username is ``'bird'`` and password ``'bebop'`` return
-        ``True``, else ``False``.
+        """If username is ``'bird'`` and password ``'bebop'`` check
+        will succeed.
+
+        Returns a tuple ``(<STATUS>, <REASON>)`` with ``<STATUS>``
+        being a boolean and ``<REASON>`` being a string giving the
+        reason why login failed (if so) or an empty string.
         """
-        return username == 'bird' and password == 'bebop'
+        reason = ''
+        result = username == 'bird' and password == 'bebop'
+        if not result:
+            reason = 'Invalid username or password.'
+        return result, reason

main/waeup.cas/trunk/waeup/cas/tests/test_authenticators.py

@@ -51 +51 @@
         auth = DummyAuthenticator()
         result1 = auth.check_credentials('bird', 'bebop')
-        assert result1 is True
+        assert result1 == (True, '')
         result2 = auth.check_credentials('foo', 'bar')
-        assert result2 is False
+        assert result2 == (False, 'Invalid username or password.')