Changeset 10248

Timestamp:

29 May 2013, 06:46:54 (11 years ago)

Author:

Henrik Bettermann

Message:

Bursary Officers are only allowed to export bursary data at all levels in academics.

Location:

main/waeup.kofa/trunk/src/waeup/kofa

Files:

• permissions.py (modified) (13 diffs)
• students/browser.py (modified) (2 diffs)
• students/tests/test_browser.py (modified) (1 diff)

main/waeup.kofa/trunk/src/waeup/kofa/permissions.py

@@ -86 +86 @@
     grok.name('waeup.local.DepartmentManager')
     grok.title(u'Department Manager')
-    grok.permissions('waeup.manageAcademics','waeup.showStudents')
+    grok.permissions('waeup.manageAcademics',
+                     'waeup.showStudents',
+                     'waeup.exportData')
 
 class ClearanceOfficer(grok.Role):
@@ -94 +96 @@
     grok.name('waeup.local.ClearanceOfficer')
     grok.title(u'Clearance Officer')
-    grok.permissions('waeup.showStudents', 'waeup.viewAcademics')
+    grok.permissions('waeup.showStudents',
+                     'waeup.viewAcademics',
+                     'waeup.exportData')
 
 class UGClearanceOfficer(grok.Role):
@@ -102 +106 @@
     grok.name('waeup.local.UGClearanceOfficer')
     grok.title(u'UG Clearance Officer')
-    grok.permissions('waeup.showStudents', 'waeup.viewAcademics')
+    grok.permissions('waeup.showStudents',
+                     'waeup.viewAcademics',
+                     'waeup.exportData')
 
 class PGClearanceOfficer(grok.Role):
@@ -110 +116 @@
     grok.name('waeup.local.PGClearanceOfficer')
     grok.title(u'PG Clearance Officer')
-    grok.permissions('waeup.showStudents', 'waeup.viewAcademics')
+    grok.permissions('waeup.showStudents',
+                     'waeup.viewAcademics',
+                     'waeup.exportData')
 
 class CourseAdviser100(grok.Role):
@@ -118 +126 @@
     grok.name('waeup.local.CourseAdviser100')
     grok.title(u'Course Adviser 100L')
-    grok.permissions('waeup.showStudents', 'waeup.viewAcademics')
+    grok.permissions('waeup.showStudents',
+                     'waeup.viewAcademics',
+                     'waeup.exportData')
 
 class CourseAdviser200(grok.Role):
@@ -126 +136 @@
     grok.name('waeup.local.CourseAdviser200')
     grok.title(u'Course Adviser 200L')
-    grok.permissions('waeup.showStudents', 'waeup.viewAcademics')
+    grok.permissions('waeup.showStudents',
+                     'waeup.viewAcademics',
+                     'waeup.exportData')
 
 class CourseAdviser300(grok.Role):
@@ -134 +146 @@
     grok.name('waeup.local.CourseAdviser300')
     grok.title(u'Course Adviser 300L')
-    grok.permissions('waeup.showStudents', 'waeup.viewAcademics')
+    grok.permissions('waeup.showStudents',
+                     'waeup.viewAcademics',
+                     'waeup.exportData')
 
 class CourseAdviser400(grok.Role):
@@ -142 +156 @@
     grok.name('waeup.local.CourseAdviser400')
     grok.title(u'Course Adviser 400L')
-    grok.permissions('waeup.showStudents', 'waeup.viewAcademics')
+    grok.permissions('waeup.showStudents',
+                     'waeup.viewAcademics',
+                     'waeup.exportData')
 
 class CourseAdviser500(grok.Role):
@@ -150 +166 @@
     grok.name('waeup.local.CourseAdviser500')
     grok.title(u'Course Adviser 500L')
-    grok.permissions('waeup.showStudents', 'waeup.viewAcademics')
+    grok.permissions('waeup.showStudents',
+                     'waeup.viewAcademics',
+                     'waeup.exportData')
 
 class CourseAdviser600(grok.Role):
@@ -158 +176 @@
     grok.name('waeup.local.CourseAdviser600')
     grok.title(u'Course Adviser 600L')
-    grok.permissions('waeup.showStudents', 'waeup.viewAcademics')
+    grok.permissions('waeup.showStudents',
+                     'waeup.viewAcademics',
+                     'waeup.exportData')
 
 class CourseAdviser700(grok.Role):
@@ -166 +186 @@
     grok.name('waeup.local.CourseAdviser700')
     grok.title(u'Course Adviser 700L')
-    grok.permissions('waeup.showStudents', 'waeup.viewAcademics')
+    grok.permissions('waeup.showStudents',
+                     'waeup.viewAcademics',
+                     'waeup.exportData')
 
 class CourseAdviser800(grok.Role):
@@ -174 +196 @@
     grok.name('waeup.local.CourseAdviser800')
     grok.title(u'Course Adviser 800L')
-    grok.permissions('waeup.showStudents', 'waeup.viewAcademics')
+    grok.permissions('waeup.showStudents',
+                     'waeup.viewAcademics',
+                     'waeup.exportData')
 
 class Lecturer(grok.Role):
@@ -182 +206 @@
     grok.name('waeup.local.Lecturer')
     grok.title(u'Lecturer')
-    grok.permissions('waeup.showStudents', 'waeup.viewAcademics')
+    grok.permissions('waeup.showStudents',
+                     'waeup.viewAcademics',
+                     'waeup.exportData')
 
 class Owner(grok.Role):

main/waeup.kofa/trunk/src/waeup/kofa/students/browser.py

@@ -2875 +2875 @@
     def _set_exporter_values(self):
         # We provide all student exporters, nothing else, yet.
+        # Bursary Officers don't have the general exportData permission
+        # and are only allowed to export bursary data.
+        if not checkPermission('waeup.exportData', self.context):
+            self.exporters = [('Bursary Data', 'bursary')]
+            return
         exporters = []
         for name in EXPORTER_NAMES:
@@ -2947 +2952 @@
     """
     grok.context(VirtualFacultiesExportJobContainer)
-
-    def _set_exporter_values(self):
-        # Only Bursary Officers will use this export. They must
-        # not be allowed to export regular student data at faculties level
-        self.exporters = [('Bursary Data', 'bursary')]
-        return
 
 class DepartmentExportJobContainerJobConfig(ExportJobContainerJobConfig):

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_browser.py

@@ -2886 +2886 @@
         self.browser.getControl("Configure new export").click()
         # Only the bursary exporter us available ot this level
-        self.assertFalse('<option value="students">' in self.browser.contents)
-        self.assertTrue('<option value="bursary">' in self.browser.contents)
+        #self.assertFalse('<option value="students">' in self.browser.contents)
+        #self.assertTrue('<option value="bursary">' in self.browser.contents)
         self.browser.getControl(name="exporter").value = ['bursary']
         self.browser.getControl(name="session").value = ['2004']